Skip to content

fix: canonicalize native build job names#139

Merged
vigneshrajsb merged 1 commit intomainfrom
fix/native-build-job-name-canonicalization
Mar 21, 2026
Merged

fix: canonicalize native build job names#139
vigneshrajsb merged 1 commit intomainfrom
fix/native-build-job-name-canonicalization

Conversation

@vigneshrajsb
Copy link
Contributor

Summary

  • add a shared canonical path for native build job names so truncation preserves the full build-<jobId>-<sha> suffix
  • switch native build job creation to the canonical helper instead of raw .substring(0, 63) truncation
  • add regression coverage for the trailing-dash case seen with subs-process-cancellations-solitary-glitter-950234

Context

  • this is the same truncation class fixed in fix: canonicalize deploy job names #136, but in the native build path rather than the deploy job paths
  • before this change, long deploy UUIDs could produce a job name ending in -, which Kubernetes rejects for both the Job name and generated pod-template labels

Testing

  • pnpm exec jest --runInBand src/server/lib/kubernetes/tests/jobNames.test.ts src/server/lib/nativeBuild/tests/buildkit.test.ts

@vigneshrajsb vigneshrajsb requested a review from a team as a code owner March 20, 2026 23:54
@vigneshrajsb vigneshrajsb merged commit 63eb6d9 into main Mar 21, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant