Feat: Add GoodBridge page to src/pages/gd #628#629
Open
Gutopro wants to merge 2 commits intoGoodDollar:masterfrom
Open
Feat: Add GoodBridge page to src/pages/gd #628#629Gutopro wants to merge 2 commits intoGoodDollar:masterfrom
Gutopro wants to merge 2 commits intoGoodDollar:masterfrom
Conversation
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The new
src/pages/gd/GoodBridge/index.tsx~file looks like an editor backup/temporary file and should be removed from the PR. - On the GoodBridge page, the placeholder text says 'Connect a wallet to see your portfolio', which is confusing for a bridge view; consider updating the copy to mention bridging instead of portfolio.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new `src/pages/gd/GoodBridge/index.tsx~` file looks like an editor backup/temporary file and should be removed from the PR.
- On the GoodBridge page, the placeholder text says 'Connect a wallet to see your portfolio', which is confusing for a bridge view; consider updating the copy to mention bridging instead of portfolio.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR integrates the MessagePassingBridge
About #628
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist:
mobile view
Summary by Sourcery
Add a new GoodBridge page that integrates the message-passing bridge into the GoodDollar app and expose it via navigation and routing.
New Features:
Enhancements: