This repository was archived by the owner on Sep 13, 2022. It is now read-only.
Split out forks into their own classes#28
Merged
Glennmen merged 21 commits intoGlennmen:masterfrom Sep 18, 2017
CalamityJames:classes
Merged
Split out forks into their own classes#28Glennmen merged 21 commits intoGlennmen:masterfrom CalamityJames:classes
Glennmen merged 21 commits intoGlennmen:masterfrom
CalamityJames:classes
Conversation
|
I don't know if you'll want this, but this is a lib file for Asner's Monocle PR, not his fork. Maybe this isn't Asner.. but it's for this Monocle PR: Noctem/Monocle#306 |
|
Now setup, yet monkey fork. |
|
With this new PR, with RM default I always get this error: |
cptmedic
suggested changes
Sep 13, 2017
Thanks @captainmedic !
Collaborator
Author
|
@captainmedic Done, thanks for the suggestion! |
|
Sloppys fork seems to be working good. |
|
Works perfectly well with lastest commit :p |
cptmedic
approved these changes
Sep 17, 2017
Contributor
|
Monkey branch works on CentOS 7. I have not test the discord include button as the discord is private, but everything else that I use is confirmed working on my instances |
This was referenced Sep 18, 2017
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Large rework of the way forks are handled, splitting out into their own classes.
This makes adding support for an extra fork much easier.
I have also converted #26 to work with the new class system, thanks go to @wateredstorm for his work on that :)
Forks tested:
I am open to any suggestions or improvements for how we handle new classes, at the moment they are all loaded in an array in
config/default.phpI have also merged in #13 to here, as it saves having multiple PRs open from me!