fix: hash refresh tokens at rest in the database#113
Open
GitAddRemote wants to merge 1 commit intomainfrom
Open
fix: hash refresh tokens at rest in the database#113GitAddRemote wants to merge 1 commit intomainfrom
GitAddRemote wants to merge 1 commit intomainfrom
Conversation
Store SHA-256(token) in the database instead of the raw token value. The raw token is returned to the caller only; the hash is used for all DB lookups and updates. Existing plaintext tokens become invalid on deploy — users must re-login (acceptable per spec). - Add private hashToken() helper using crypto.sha256 - generateRefreshToken: saves hash, returns raw value - refreshAccessToken: hashes incoming token before lookup - revokeRefreshToken: hashes incoming token before update Closes #96
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SHA-256(raw_token)in therefresh_tokenstablerefreshAccessToken,revokeRefreshToken) hash the incoming token before queryingWhy SHA-256 (not bcrypt)
Input has 256 bits of entropy so rainbow tables are infeasible. bcrypt is intentionally slow — this is a hot lookup path and the entropy argument makes the slowness unnecessary.
Test plan
refresh_tokenstable — no plaintext tokens presentCloses #96