fix: remove debug artifacts and fix password reset token log exposure#112
Open
GitAddRemote wants to merge 1 commit intomainfrom
Open
fix: remove debug artifacts and fix password reset token log exposure#112GitAddRemote wants to merge 1 commit intomainfrom
GitAddRemote wants to merge 1 commit intomainfrom
Conversation
- Delete GET /auth/test debug endpoint and bcrypt import - Remove raw reset token and reset URL from application logs; replace with neutral 'Password reset requested for user ID: X' log entry - Gate Swagger UI behind NODE_ENV !== 'production' - Remove persistAuthorization from Swagger options Closes #99
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /auth/testdebug endpoint and itsbcryptimport fromAuthControllerrequestPasswordReset()that leaked the raw token and reset URL with a single neutral log:Password reset requested for user ID: X/api/docs) behindNODE_ENV !== 'production'persistAuthorization: truefrom Swagger optionsTest plan
GET /auth/testreturns 404POST /auth/forgot-passwordlogs onlyPassword reset requested for user ID: X— no token, no URL/api/docsin development (NODE_ENV=development)NODE_ENV=productionCloses #99