Skip to content

Point MPG users to canonical Gecode skills repository#5

Open
zayenz wants to merge 4 commits intopython-build-scriptsfrom
codex/skills-pr3
Open

Point MPG users to canonical Gecode skills repository#5
zayenz wants to merge 4 commits intopython-build-scriptsfrom
codex/skills-pr3

Conversation

@zayenz
Copy link
Copy Markdown
Member

@zayenz zayenz commented Feb 18, 2026

Summary

  • add canonical install guidance in MPG README pointing to Gecode/gecode-skills
  • add skills/README.md documenting that MPG skills/ is a reference snapshot, not the publish source
  • keep skills/install-skills.sh for local snapshot installation, with explicit canonical-source notice

Policy Chosen

  • keep MPG skills as reference snapshots to avoid workflow breakage and drift surprises during transition
  • canonical published skills now come from Gecode/gecode-skills

User-facing install path

npx skills add Gecode/gecode-skills

Notes

  • this PR only updates documentation/local snapshot messaging
  • release automation remains in Gecode/gecode-skills

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 38466ae77b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +9 to +12
DEST="${1:-${CODEX_HOME:-$DEST_DEFAULT}/skills}"

if [[ "$DEST" == "$HOME/.codex/skills/skills" ]]; then
DEST="$HOME/.codex/skills"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Normalize destination path when CODEX_HOME already ends with skills

The destination is built as ${CODEX_HOME}/skills, but DEST_DEFAULT already includes skills, and the subsequent fix-up only handles the hard-coded $HOME/.codex/skills/skills case. If a user sets CODEX_HOME to a custom path that already points at a skills directory (for example in CI/dev containers), this script installs into <path>/skills/skills, so Codex won’t read the newly copied skills from the expected location.

Useful? React with 👍 / 👎.

@greptile-apps
Copy link
Copy Markdown

greptile-apps bot commented Feb 18, 2026

Greptile Summary

This PR adds the entire skills/ directory (18 new files) to MPG, establishing seven Gecode skill definitions as local reference snapshots while directing users to install canonical published skills from Gecode/gecode-skills. The README is updated with install instructions.

  • Documentation: README.md gains a "Gecode Skills" section with npx skills add commands; skills/README.md clarifies the snapshot policy
  • Seven skill definitions: Each skill has a SKILL.md (structured markdown with frontmatter) and an agents/openai.yaml (agent interface config), covering general knowledge, modeling, propagator/brancher/search-engine implementation, search engine usage, and memory handling
  • Install script bug: skills/install-skills.sh has a fragile default path computation that double-appends /skills — the workaround guard only catches the default case
  • Local paths leaked: skills/case-study-skill-audit.md contains hardcoded /Users/zayenz/... paths that should be repository-relative

Confidence Score: 4/5

  • This PR is primarily documentation and skill definitions with low runtime risk; the install script has a path bug but is a local-only tool.
  • Score of 4 reflects that the bulk of changes are documentation/markdown with no impact on the core codebase. The install script path logic issue is a real bug but only affects local snapshot installation, not the canonical install path. The hardcoded local paths in the audit file are a style concern.
  • skills/install-skills.sh (path computation bug), skills/case-study-skill-audit.md (hardcoded local filesystem paths)

Important Files Changed

Filename Overview
README.md Adds a "Gecode Skills" section documenting the canonical install path via Gecode/gecode-skills and clarifying the local snapshot policy. Clean documentation addition.
skills/README.md New README pointing users to the canonical Gecode/gecode-skills repository and explaining this directory is a reference snapshot. Clear and concise.
skills/case-study-skill-audit.md Audit document with per-case-study findings and skill mapping. Contains hardcoded local filesystem paths (/Users/zayenz/...) that should be repository-relative.
skills/install-skills.sh Shell script for local snapshot installation. Contains a path computation bug: DEST_DEFAULT already includes /skills, but line 9 unconditionally appends /skills again, with a fragile hardcoded guard to work around only the default case.
skills/gecode-brancher-implementation/SKILL.md New skill document covering Gecode brancher implementation patterns, choice mechanics, and pitfalls. Well-structured with core concepts, key patterns, and pitfalls sections.
skills/gecode-general-knowledge/SKILL.md Core Gecode architecture skill covering spaces, propagation lifecycle, cloning, and recomputation. Well-structured reference document.
skills/gecode-memory-handling/SKILL.md Memory handling skill covering space/region/heap allocation, shared/local handles, and disposal patterns. Comprehensive and well-organized.
skills/gecode-modeling/SKILL.md Modeling skill covering CP problem formulation, constraints, branchings, search configuration, and common pitfalls. Thorough reference document.
skills/gecode-propagator-implementation/SKILL.md Propagator implementation skill with detailed coverage of posting, lifecycle, advisors, reification, and rewriting patterns. Comprehensive reference.
skills/gecode-search-engine-implementation/SKILL.md Search engine implementation skill covering recomputation strategies, branch-and-bound, and invariants. Well-structured with dedicated invariants section.
skills/gecode-search-engines/SKILL.md Search engines usage skill covering DFS/BAB/LDS/RBS/PBS selection, no-good nuances, and parallel semantics. Clear distinction from the implementation skill.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[User wants Gecode skills] --> B{Install method?}
    B -->|Canonical| C["npx skills add Gecode/gecode-skills"]
    B -->|Local snapshot| D["skills/install-skills.sh"]
    C --> E["Gecode/gecode-skills repo"]
    E --> F["~/.codex/skills/"]
    D --> G["MPG skills/ directory"]
    G --> F
    H["README.md"] -->|Documents| C
    I["skills/README.md"] -->|Clarifies snapshot policy| G
Loading

Last reviewed commit: 38466ae

Copy link
Copy Markdown

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

18 files reviewed, 3 comments

Edit Code Review Agent Settings | Greptile

Comment on lines +8 to +9
DEST_DEFAULT="${HOME}/.codex/skills"
DEST="${1:-${CODEX_HOME:-$DEST_DEFAULT}/skills}"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fragile default-path computation

DEST_DEFAULT is already $HOME/.codex/skills, so when CODEX_HOME is unset the expression ${CODEX_HOME:-$DEST_DEFAULT}/skills evaluates to $HOME/.codex/skills/skills — a double /skills suffix. The guard on lines 11-13 only catches this specific default; if a user sets CODEX_HOME="$HOME/.codex/skills" the same double-append occurs and the guard won't fire.

Consider dropping the /skills suffix from DEST_DEFAULT so the append on line 9 produces the correct path in all cases:

Suggested change
DEST_DEFAULT="${HOME}/.codex/skills"
DEST="${1:-${CODEX_HOME:-$DEST_DEFAULT}/skills}"
DEST_DEFAULT="${HOME}/.codex"
DEST="${1:-${CODEX_HOME:-$DEST_DEFAULT}/skills}"

This also makes the special-case guard on lines 11-13 unnecessary.

@@ -0,0 +1,43 @@
# MPG Case-Study Skill Audit

Scope: `/Users/zayenz/gecode/MPG/docs/src/chapters/case-studies/*.tex.in`
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardcoded local filesystem path

This line (and lines 37-41 below) contains an absolute path from a development machine (/Users/zayenz/gecode/MPG/...). Since this file is committed to the repository, these should be repository-relative paths instead.

Suggested change
Scope: `/Users/zayenz/gecode/MPG/docs/src/chapters/case-studies/*.tex.in`
Scope: `docs/src/chapters/case-studies/*.tex.in`

Comment on lines +37 to +41
- Updated `/Users/zayenz/gecode/MPG/skills/gecode-general-knowledge/SKILL.md`
- Updated `/Users/zayenz/gecode/MPG/skills/gecode-modeling/SKILL.md`
- Updated `/Users/zayenz/gecode/MPG/skills/gecode-propagator-implementation/SKILL.md`
- Updated `/Users/zayenz/gecode/MPG/skills/gecode-brancher-implementation/SKILL.md`
- Updated `/Users/zayenz/gecode/MPG/skills/gecode-memory-handling/SKILL.md`
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More hardcoded local paths

Same issue as line 3 — these absolute paths should be repository-relative for portability.

Suggested change
- Updated `/Users/zayenz/gecode/MPG/skills/gecode-general-knowledge/SKILL.md`
- Updated `/Users/zayenz/gecode/MPG/skills/gecode-modeling/SKILL.md`
- Updated `/Users/zayenz/gecode/MPG/skills/gecode-propagator-implementation/SKILL.md`
- Updated `/Users/zayenz/gecode/MPG/skills/gecode-brancher-implementation/SKILL.md`
- Updated `/Users/zayenz/gecode/MPG/skills/gecode-memory-handling/SKILL.md`
- Updated `skills/gecode-general-knowledge/SKILL.md`
- Updated `skills/gecode-modeling/SKILL.md`
- Updated `skills/gecode-propagator-implementation/SKILL.md`
- Updated `skills/gecode-brancher-implementation/SKILL.md`
- Updated `skills/gecode-memory-handling/SKILL.md`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant