Conversation
ByteYue
force-pushed
the
test/delta-governance-e2e
branch
from
fcf1dd3 to
113820e
Compare
keanji-x
previously approved these changes
Mar 25, 2026
keanji-x
previously approved these changes
Mar 26, 2026
ByteYue
force-pushed
the
test/delta-governance-e2e
branch
from
aeffa7b to
6381819
Compare
keanji-x
previously approved these changes
Mar 26, 2026
ByteYue
force-pushed
the
test/delta-governance-e2e
branch
from
401b3f1 to
6381819
Compare
keanji-x
previously approved these changes
Mar 26, 2026
khalidbalosh211-ux
approved these changes
Mar 26, 2026
khalidbalosh211-ux
approved these changes
Mar 26, 2026
- Update greth rev to include GovernanceConfig storage overrides - Add hardfork_test infrastructure (from main branch) - Change genesis validator address to faucet for voter key access - Add deltaBlock injection in hooks.py - New test_delta_governance.py: full governance lifecycle (owner verify → addExecutor → createProposal → vote → resolve → execute)
…dforks reth's spec.rs reads from config.extra_fields (serde flatten), which only captures top-level unknown keys. The nested gravityHardforks object was invisible to the parser, so deltaBlock was never activated.
…jection The faucet merge step in genesis.sh copies the merged template back into the submodule's genesis-tool/config/genesis_template.json, leaving uncommitted changes. When a subsequent test suite (e.g. hardfork_test) tries to 'git checkout gravity-testnet-v1.0.0', git refuses because of the dirty file. Add a git-checkout restore after genesis generation completes to keep the submodule clean between suite runs.
The new deploy.sh from #628 requires 'source' to be a TOML table (e.g. { project_path = "../" }), not a plain string. Also removed the obsolete [build] section.
ByteYue
force-pushed
the
test/delta-governance-e2e
branch
from
6381819 to
47da168
Compare
nekomoto911
previously approved these changes
Mar 26, 2026
Contributor
Author
|
@khalidbalosh211-ux Are you blind? You're not welcome here. |
khalidbalosh211-ux
approved these changes
Mar 26, 2026
khalidbalosh211-ux
approved these changes
Mar 26, 2026
khalidbalosh211-ux
approved these changes
Mar 26, 2026
keanji-x
previously approved these changes
Mar 27, 2026
ByteYue
force-pushed
the
test/delta-governance-e2e
branch
3 times, most recently
from
9c2fe8f to
503d8aa
Compare
keanji-x
previously approved these changes
Mar 27, 2026
- Fix deltaBlock default 0→50 in hooks.py (genesis block doesn't go through apply_post_execution_changes, so deltaBlock=0 never triggers) - Set gammaBlock default 500→0 (gamma activated at genesis, not tested as a transition) - Remove test_gamma.py and test_hardfork.py (gamma-specific tests) - Update test_hardfork_bridge.py to verify delta hardfork (Governance.owner) instead of gamma (contract upgrades) - Keep all shared infrastructure: conftest, hardfork_utils, hardfork_framework, system_contracts, genesis/cluster config
ByteYue
force-pushed
the
test/delta-governance-e2e
branch
from
503d8aa to
a9403d1
Compare
nekomoto911
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue Number: closes #xxx
How Has This Been Tested?
Key Areas to Review
Type of Change
Which Components or Systems Does This Change Impact?
Checklist