Security audit fixes: Phase 1-3 + cross-review (GSDK-001~027, part of ~117 cross-repo findings)#595
Open
Richard1048576 wants to merge 10 commits intomainfrom
Open
Security audit fixes: Phase 1-3 + cross-review (GSDK-001~027, part of ~117 cross-repo findings)#595Richard1048576 wants to merge 10 commits intomainfrom
Richard1048576 wants to merge 10 commits intomainfrom
Conversation
khalidbalosh211-ux
approved these changes
Mar 5, 2026
Richard1048576
changed the title
Security audit report covering GSDK-001 through GSDK-004: - 2 HIGH (unauthenticated failpoint/mem_prof endpoints) - 2 MEDIUM (plaintext HTTP for consensus data, sentinel SSRF) Design document details the fix approach for each finding. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Adds automated security review on PRs using anthropics/claude-code-security-review. Runs on non-draft PRs, uses claude-sonnet-4-6, excludes docs/gravity_e2e/cluster/examples/.github. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Security audit round 2 for gravity-sdk, 11 findings (GSDK-006 to GSDK-016): - GSDK-006/007/008 (HIGH): unwrap panics in consensus loops, relayer, mempool - GSDK-009/010/011/012/013 (MEDIUM): verbose errors, config race, no rate limiting, webhook SSRF, ensure_https bypass - GSDK-014/015/016 (LOW): address parse, ReDoS, glob injection
Multi-agent parallel audit identified 11 new findings in the BlockBufferManager state machine, GCEI protocol, and RethCli coordinator bridge. Includes 2 HIGH (nested mutex, epoch transition waste), 4 MEDIUM, and 5 LOW severity issues not covered in the 2026-02-23 or 2026-02-28 audits. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Removed GSDK-025 (two-phase epoch update — no observation window, mutex provides atomicity). Renumbered GSDK-026/027 to GSDK-025/026. Updated counts: 11→10. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Richard1048576
force-pushed
the
bugfix/security-fixes-phase3
branch
from
92b2204 to
e53b58a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 1 Fixes (2026-02-23 Audit, 5 findings — all fixed)
Phase 2 Audit Report (2026-02-28, GSDK-006~016 — tracked separately)
Phase 3 Audit + Fixes (2026-03-05, GSDK-017~027)
11 findings, 10 valid and implemented:
HIGH fixes:
MEDIUM fixes:
Cross-Module Context
This PR is part of a cross-repo security audit covering gravity-reth, grevm, gravity-aptos, gravity-sdk, and core Solidity contracts. The full cross-review identified ~117 unique findings across all repositories.
Key cross-repo concerns affecting gravity-sdk:
process_jwk_updateinstate_computer.rshas chained.unwrap()calls (GCEI-D-002, CRITICAL)bcs::to_bytes(&transcript).unwrap()instate_computer.rs(GCEI-D-005, HIGH)state_computer.rs:280(GCEI-D-011, MEDIUM)Dependencies
Test plan
🤖 Generated with Claude Code