feature: cors 설정 변경 및 디스코드 웹 훅 주소 변경

[Jjiggu]

작업 요약

• 디스코드 웹훅 해킹 공격으로 인한 주소 변경
• 프론트 배포서버 사용을 위한 cors 서버 추가

Issue Link

문제점 및 어려움

해결 방안

Reference

Summary by CodeRabbit

• 신규 기능

  • 서비스에 접근할 수 있는 허용 도메인 목록이 확장되어, 프로덕션 및 스테이징 URL이 추가되었습니다.

• 환경설정

  • Discord 웹훅 URL이 외부 환경설정에서 관리되도록 개선되어, 운영 환경에 따라 유연하게 설정할 수 있습니다.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

CORS 설정이 확장되어 허용된 오리진 목록에 프로덕션 및 스테이징 도메인이 추가되었습니다. Discord Webhook Feign 클라이언트의 URL 하드코딩이 제거되고, 외부 프로퍼티로 URL을 설정할 수 있도록 변경되었습니다. 공개 엔티티의 시그니처 변경은 없습니다.

Changes

Cohort / File(s)	Change Summary
CORS 오리진 확장 nowait-app-user-api/src/main/java/com/nowait/applicationuser/config/security/CorsConfig.java	CORS 허용 오리진에 프로덕션 및 스테이징 도메인 3개 추가, 기존 localhost만 허용하던 부분 확장
Discord Webhook URL 외부화 nowait-infra/src/main/java/com/nowait/discord/client/DiscordClientAdmin.java, nowait-infra/src/main/java/com/nowait/discord/client/DiscordClientUser.java	Discord Webhook Feign 클라이언트의 URL 하드코딩을 제거하고, 프로퍼티 플레이스홀더로 외부 설정 가능하게 변경

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant API Server
    participant Discord Webhook

    Client->>API Server: 요청 (CORS 오리진 포함)
    API Server-->>Client: CORS 정책 적용 (확장된 오리진 허용)

    API Server->>Discord Webhook: Feign Client 호출 (URL은 외부 프로퍼티에서 주입)
    Discord Webhook-->>API Server: 응답

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• refactor: setAllowCredentials 설정 추가 #127: CORS 설정에서 credentials 허용을 추가하는 PR로, 본 PR과 동일한 CORS 설정 파일을 수정하지만 포커스가 다름.
• refactor(APIAdmin,APIUser): cors 해결 #38: CORS 허용 오리진 확장 및 CorsConfig 모듈 통합 관련 PR로, 본 PR과 유사하게 CORS 설정 개선에 중점.

Suggested labels

enhancement

Suggested reviewers

• HyemIin

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fceff3f and f164ddc.

📒 Files selected for processing (3)

• nowait-app-user-api/src/main/java/com/nowait/applicationuser/config/security/CorsConfig.java (1 hunks)
• nowait-infra/src/main/java/com/nowait/discord/client/DiscordClientAdmin.java (1 hunks)
• nowait-infra/src/main/java/com/nowait/discord/client/DiscordClientUser.java (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feature/#224-health-check

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.