GPII-4489 Site Config Option to enable/disable capture tool.#210
Open
sgithens wants to merge 1 commit intoGPII:masterfrom
Open
GPII-4489 Site Config Option to enable/disable capture tool.#210sgithens wants to merge 1 commit intoGPII:masterfrom
sgithens wants to merge 1 commit intoGPII:masterfrom
Conversation
…ely include Capture Tool
|
CI job passed: https://ci.gpii.net/job/gpii-app-tests/1194/ |
amb26
reviewed
Jun 24, 2020
| * @param {String} label - The label of the item. | ||
| * @param {String} event - The event to be triggered on click. | ||
| * @param {Object} [payload] - The payload that is to be supplied with the on click event. | ||
| * @return {ElectronMenuItem} A simple selectable Electron menu item. |
Member
There was a problem hiding this comment.
Declare that the return is optional - e.g. {ElectronMenuItem|Undefined}
amb26
reviewed
Jun 24, 2020
| * @return {ElectronMenuItem} A simple selectable Electron menu item. | ||
| */ | ||
| gpii.app.menu.getOptionalMenuItem = function (hideItem, label, event, payload) { | ||
| if (hideItem) { |
Member
There was a problem hiding this comment.
I'm not a religious fanatic, but single (and explicit) return-ism is slightly preferable - how about
return hideItem ? undefined : {
label: label,
click: event,
args: payload || {}
};
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding optional menu item generation to be able to selectively include Capture Tool