GPII-4439: Buttons GREY if they will not work with this version of Morphic #191
Open
Karadaliev wants to merge 3 commits intoGPII:masterfrom
Open
GPII-4439: Buttons GREY if they will not work with this version of Morphic #191Karadaliev wants to merge 3 commits intoGPII:masterfrom
Karadaliev wants to merge 3 commits intoGPII:masterfrom
Conversation
…showing them disabled with the appropriate tooltip and even a notification when clicked.
…, or wrong buttonType it's creating a unknown type button instead.
|
Could one of the admins verify that these changes are reasonable to test? If so, please reply with "ok to test". |
Member
|
ok to test |
|
CI job failed: https://ci.gpii.net/job/gpii-app-tests/1056/ |
Member
ok to test |
|
CI job failed: https://ci.gpii.net/job/gpii-app-tests/1057/ |
|
CI job passed: https://ci.gpii.net/job/gpii-app-tests/1139/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds new unknown type of buttons with his handler (showing the proper tooltip and when click it a specific notification message) for both standard buttons that are missing from settings.json definitions, and custom buttons from unknown types, or missing required data fields.
For testing purposes you can add random non-existing buttonId in siteConfig > qss > buttonList, or in the same variable change one of the custom button types for something different that "WEB", "APP", or "KEY".