feat: Adding a fault stability analysis workflow#232
feat: Adding a fault stability analysis workflow#232paloma-martinez wants to merge 21 commits intomainfrom
Conversation
paloma-martinez
added
the
test-geos-integration
RomainBaville
left a comment
RomainBaville
left a comment
There was a problem hiding this comment.
Thanks for the job.
I made some suggestion but I have two additionnal global comment:
There is some caracter in the code that can lead to issues (greek letters, emoticon, arrows). To avoid that, you may change them.
In your code, some warning can be convert to error and the error managment can be updated (raise and not log error, use the CountVerbosityHandler ...)
|
|
||
| pvdPath = self.vtuOutputDir / filename | ||
|
|
||
| self.logger.info( f"\n💾 Creating PVD collection: {pvdPath}" |
There was a problem hiding this comment.
| self.logger.info( f"\n💾 Creating PVD collection: {pvdPath}" | |
| self.logger.info( f"💾 Creating PVD collection: {pvdPath}\n" |
RomainBaville
left a comment
RomainBaville
left a comment
There was a problem hiding this comment.
Thanks for the job.
I made some suggestion but I have two additionnal global comment:
There is some caracter in the code that can lead to issues (greek letters, emoticon, arrows). To avoid that, you may change them.
In your code, some warning can be convert to error and the error managment can be updated (raise and not log error, use the CountVerbosityHandler ...)
| self.outputDir: Path = Path( "FaultStabilityAnalysis/" ) | ||
|
|
||
| # Mechanical parameters | ||
| self.frictionAngle: float = 12 # [degrees] |
There was a problem hiding this comment.
12 is very specific usually it is 10 or 30, you may change it
| plt.savefig( os.path.join( path, filename ), dpi=300, bbox_inches='tight' ) | ||
| self.logger.info( f" 📊 Plot saved: {filename}" ) | ||
| plt.savefig( path / filename, dpi=300, bbox_inches='tight' ) | ||
| plt.savefig( str( path / filename ), dpi=300, bbox_inches='tight' ) |
There was a problem hiding this comment.
Why is this line ducplicate?
There was a problem hiding this comment.
missing clean up
|
|
||
| # Plot 2: Shear Stress | ||
| axes[ 1 ].set_xlabel( 'Shear Stress τ [bar]', fontsize=fsize, weight="bold" ) | ||
| # axes[ 1 ].set_xlabel( 'Shear Stress τ [bar]', fontsize=fsize, weight="bold" ) |
There was a problem hiding this comment.
You forgot a greek letter
| Line2D( [ 0 ], [ 0 ], color='gray', linewidth=2.5, linestyle='-', marker='o', label='σ₁ (max)' ), | ||
| Line2D( [ 0 ], [ 0 ], color='gray', linewidth=2.0, linestyle='-', marker='s', label='σ₂ (inter)' ), | ||
| Line2D( [ 0 ], [ 0 ], color='gray', linewidth=2.5, linestyle='-', marker='v', label='σ₃ (min)' ) | ||
| Line2D( [ 0 ], [ 0 ], color='gray', linewidth=2.5, linestyle='-', marker='o', label='sigma₁ (max)' ), |
There was a problem hiding this comment.
I am not sur that the indice is a correct carracter, you may change it here and after
…aultStabilityVisu' into pmartinez/feature/faultStabilityVisu
2 participants
This PR will add a post-processing workflow to analyze the fault stability and plot various results.