Conversation
6afc7b0 to
ac9226a
Compare
|
2c33aaa to
d2ad1d5
Compare
60d5ad5 to
2cc2c55
Compare
|
2cc2c55 to
2502efd
Compare
|
@fulopdaniel but how is it done in the fondue packages? As they are not running everything and only the needed jobs are shown |
There was a problem hiding this comment.
Pull request overview
This PR updates several GitHub Actions CI workflows to avoid required checks hanging on PRs that don’t touch certain packages, by removing pull_request.paths filters and adding an explicit “detect changes” gate job.
Changes:
- Remove
pull_request.pathsfilters so workflows always start on PRs. - Add a lightweight
changesjob usingdorny/paths-filter@v3to determine whether package-specific CI should run. - Conditionally skip (or effectively no-op) downstream CI jobs when the relevant package files are unchanged.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/typing-continuous-integration.yml | Adds changes job and gates the sidebar-settings CI job based on detected path changes. |
| .github/workflows/guideline-themes-continuous-integration.yml | Adds changes job and gates theme lint/typecheck + tests based on detected path changes. |
| .github/workflows/guideline-blocks-continuous-integration.yml | Adds changes job and gates matrix-based guideline-blocks jobs based on detected path changes; extends matrix versions. |
| .github/workflows/cli-continuous-integration.yml | Adds changes job and gates the CLI CI job based on detected path changes. |
| .github/workflows/app-bridge-theme-continuous-integration.yml | Adds changes job and gates app-bridge-theme CI job based on detected path changes. |
| .github/workflows/app-bridge-continuous-integration.yml | Adds changes job and gates app-bridge CI + compatibility job based on detected path changes. |
| .github/workflows/app-bridge-app-continuous-integration.yml | Adds changes job and gates app-bridge-app CI job based on detected path changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
@ragi96 Had a quick look but to me it seems like in fondue everything is always run. E.g. check this PR: |
But it's having paths: https://github.com/Frontify/fondue/blob/6c76ab618d7887b96e99b3fd9455746fc79a19f6/.github/workflows/charts-pull-requests.yaml#L6 |
94e0bff to
2502efd
Compare



Fix CI checks showing "Expected — Waiting for status to be reported" on PRs that don't touch all packages
Problem
When workflows use paths filters, the entire workflow is skipped for PRs that don't touch matching files. A skipped workflow never reports any status at all -> GitHub never sees the job names it's waiting for, so required checks are stuck on "Waiting for status to be reported" indefinitely.
Solution
Each workflow now:
Quirks
For matrix strategies (v3/v4 app bridge) the job instantly passes.
For single strategies the job is skipped.
This is due to some github quirks with matrix strategies.
Alternative approaches
We could run all the checks all the time.