Skip to content

fix(CI): some jobs are hanging#1504

Merged
ragi96 merged 6 commits intomainfrom
test/ci-test
Mar 25, 2026
Merged

fix(CI): some jobs are hanging#1504
ragi96 merged 6 commits intomainfrom
test/ci-test

Conversation

@fulopdaniel
Copy link
Copy Markdown
Collaborator

@fulopdaniel fulopdaniel commented Mar 24, 2026

Fix CI checks showing "Expected — Waiting for status to be reported" on PRs that don't touch all packages

Problem

When workflows use paths filters, the entire workflow is skipped for PRs that don't touch matching files. A skipped workflow never reports any status at all -> GitHub never sees the job names it's waiting for, so required checks are stuck on "Waiting for status to be reported" indefinitely.

Solution

Each workflow now:

  1. Always triggers on pull_request (no paths filter)
  2. Runs a lightweight changes job using dorny/paths-filter@v3 to detect relevant file changes
  3. skips/instantly passes the CI job if there are no relevant files touched.

Quirks

For matrix strategies (v3/v4 app bridge) the job instantly passes.
For single strategies the job is skipped.

This is due to some github quirks with matrix strategies.

Alternative approaches

We could run all the checks all the time.

@fulopdaniel fulopdaniel requested a review from a team as a code owner March 24, 2026 15:05
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 25, 2026

⚠️ No Changeset found

Latest commit: d4e60d3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@fulopdaniel fulopdaniel force-pushed the test/ci-test branch 2 times, most recently from 2c33aaa to d2ad1d5 Compare March 25, 2026 09:25
@fulopdaniel fulopdaniel force-pushed the test/ci-test branch 2 times, most recently from 60d5ad5 to 2cc2c55 Compare March 25, 2026 09:51
@sonarqubecloud
Copy link
Copy Markdown

@fulopdaniel fulopdaniel requested review from ragi96 and removed request for hochreutenerl March 25, 2026 10:00
@fulopdaniel fulopdaniel changed the title feat(*): just testing CI, will close PR fix(CI): some jobs are hanging Mar 25, 2026
@ragi96
Copy link
Copy Markdown
Collaborator

ragi96 commented Mar 25, 2026

@fulopdaniel but how is it done in the fondue packages? As they are not running everything and only the needed jobs are shown

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates several GitHub Actions CI workflows to avoid required checks hanging on PRs that don’t touch certain packages, by removing pull_request.paths filters and adding an explicit “detect changes” gate job.

Changes:

  • Remove pull_request.paths filters so workflows always start on PRs.
  • Add a lightweight changes job using dorny/paths-filter@v3 to determine whether package-specific CI should run.
  • Conditionally skip (or effectively no-op) downstream CI jobs when the relevant package files are unchanged.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
.github/workflows/typing-continuous-integration.yml Adds changes job and gates the sidebar-settings CI job based on detected path changes.
.github/workflows/guideline-themes-continuous-integration.yml Adds changes job and gates theme lint/typecheck + tests based on detected path changes.
.github/workflows/guideline-blocks-continuous-integration.yml Adds changes job and gates matrix-based guideline-blocks jobs based on detected path changes; extends matrix versions.
.github/workflows/cli-continuous-integration.yml Adds changes job and gates the CLI CI job based on detected path changes.
.github/workflows/app-bridge-theme-continuous-integration.yml Adds changes job and gates app-bridge-theme CI job based on detected path changes.
.github/workflows/app-bridge-continuous-integration.yml Adds changes job and gates app-bridge CI + compatibility job based on detected path changes.
.github/workflows/app-bridge-app-continuous-integration.yml Adds changes job and gates app-bridge-app CI job based on detected path changes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@fulopdaniel
Copy link
Copy Markdown
Collaborator Author

@fulopdaniel but how is it done in the fondue packages? As they are not running everything and only the needed jobs are shown

@ragi96 Had a quick look but to me it seems like in fondue everything is always run. E.g. check this PR:
Frontify/fondue#2647 , the RTE component tests are run, even though it's not touched.

@ragi96
Copy link
Copy Markdown
Collaborator

ragi96 commented Mar 25, 2026

@fulopdaniel but how is it done in the fondue packages? As they are not running everything and only the needed jobs are shown

@ragi96 Had a quick look but to me it seems like in fondue everything is always run. E.g. check this PR: Frontify/fondue#2647 , the RTE component tests are run, even though it's not touched.

But it's having paths: https://github.com/Frontify/fondue/blob/6c76ab618d7887b96e99b3fd9455746fc79a19f6/.github/workflows/charts-pull-requests.yaml#L6

@ragi96 ragi96 merged commit c0e920e into main Mar 25, 2026
28 checks passed
@ragi96 ragi96 deleted the test/ci-test branch March 25, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants