Temporarily patch out the broken auto quality selection#8908
Merged
FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom Mar 31, 2026
Merged
Temporarily patch out the broken auto quality selection#8908FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom
FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom
Conversation
PikachuEXE
approved these changes
Mar 31, 2026
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Mar 31, 2026
ChunkyProgrammer
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
Description
As fixing the broken auto-quality selection with SABR requires a more involved rewrite and we only recently discovered the issue, it was decided that it made more sense to temporarily hide the auto quality selection for 0.24.0, to avoid users triggering the broken code paths and being confronted with error messages because of it. The initial auto quality selection works fine, the issue is when auto triggers a quality change e.g. network conditions changing or resizing the player/pip window.
If auto was set as the default quality before it is overriden at runtime to 720p which is the default value of the
defaultQualitysetting, it doesn't actually modify the databases unless the user manually changes the default quality.The changes are intentionally as minimal as possible with the same todo comment next to each changed line, so make it easier to undo/revert in the future.
Testing
Desktop