Skip to content

Temporarily patch out the broken auto quality selection#8908

Merged
FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom
absidue:temporarily-patch-auto
Mar 31, 2026
Merged

Temporarily patch out the broken auto quality selection#8908
FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom
absidue:temporarily-patch-auto

Conversation

@absidue
Copy link
Copy Markdown
Member

@absidue absidue commented Mar 30, 2026

Pull Request Type

  • Bugfix

Related issue

Description

As fixing the broken auto-quality selection with SABR requires a more involved rewrite and we only recently discovered the issue, it was decided that it made more sense to temporarily hide the auto quality selection for 0.24.0, to avoid users triggering the broken code paths and being confronted with error messages because of it. The initial auto quality selection works fine, the issue is when auto triggers a quality change e.g. network conditions changing or resizing the player/pip window.

If auto was set as the default quality before it is overriden at runtime to 720p which is the default value of the defaultQuality setting, it doesn't actually modify the databases unless the user manually changes the default quality.

The changes are intentionally as minimal as possible with the same todo comment next to each changed line, so make it easier to undo/revert in the future.

Testing

  1. Set your default quality to auto before checking out this branch
  2. Check that the auto option doesn't show up in the default quality setting or the video player resolution and audio quality menus and that it is overridden to 720p.

Desktop

  • OS: Windows
  • OS Version: 11

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) March 30, 2026 21:47
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Mar 30, 2026
@FreeTubeBot FreeTubeBot merged commit c799592 into FreeTubeApp:development Mar 31, 2026
6 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Mar 31, 2026
@absidue absidue deleted the temporarily-patch-auto branch March 31, 2026 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants