Move skip popups to the edges of the screen#8877
Open
caetano-dev wants to merge 4 commits intoFreeTubeApp:developmentfrom
Open
Move skip popups to the edges of the screen#8877caetano-dev wants to merge 4 commits intoFreeTubeApp:developmentfrom
caetano-dev wants to merge 4 commits intoFreeTubeApp:developmentfrom
Conversation
github-actions
bot
added
the
PR: waiting for review
src/renderer/components/ft-shaka-video-player/ft-shaka-video-player.css
Outdated
Show resolved
Hide resolved
auto-merge was automatically disabled
March 26, 2026 15:14
Head branch was pushed to by a user without write access
absidue
changed the title
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Mar 28, 2026
efb4f5ff-1298-471a-8973-3d47447115dc
requested review from
PikachuEXE and
absidue
Member
|
I think having to look at different places for the notification is bad for UX Note: especially on 4K fullscreen |
Member
|
Hmm tbh i didnt think of that. Also dont have an argument against so ill let the others chime in and be the deciding factor |
github-actions
bot
added
PR: merge conflicts / rebase needed
and removed
PR: waiting for review
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
This is an improvement from PR #8870, as suggested by this comment #8870 (review)
Description
This PR moves the skip popups to the right or left side, making it easier for the user to understand what is happening.
Screenshots
Testing
Desktop