Merged
Conversation
…e sphinx dependencies
… having getting started section
Author
|
@nichollsh I implemented your suggestions and made a few more changes. What do you think? |
Member
|
Looks good! I agree that writing the name as Aragog is better than as 'aragog'. The former comes across as incomplete. |
timlichtenberg
requested changes
Feb 16, 2026
Member
timlichtenberg
left a comment
There was a problem hiding this comment.
looks very good, a few final suggestions, then let's merge tomorrow :>
Co-authored-by: Tim Lichtenberg <lichtenberg.tim@gmail.com>
Co-authored-by: Tim Lichtenberg <lichtenberg.tim@gmail.com>
Member
|
Rapid! Happy to re-review in a couple of minutes. |
Author
I should have covered everything now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR builds documentation for aragog according to the Diataxis approach. Closes FormingWorlds/PROTEUS#544.
It uses some original Sphinx documentation in ExPlanetology/aragog (converted to Markdown), but the vast majority is new. The documentation itself is divided into:
Documentation files
index.md)getting_started.md), shortly explains tutorials/howtos/explanations/reference and points to installation/firstrun tutorialinstallation.md) and an how-to on using NetCDF output files (netcdf.md)firstrun.md)model.md)publications.md) and a full api reference making use of mkdocstrings (api.md)CODE_OF_CONDUCT.md)Other files
mkdocs.yml: the mkdocs configuration file.github/workflows/docs.yaml: builds the documentation via github pagesdocs/stylesheets/extra.css: necessary to render docstrings correctly in the api overviewassets/includes PROTEUS logosoverrides/: a directory with a few files to force the favicon (in the browser search bar) to switch color depending on dark/light mode in chrome, safari, and firefoxsource code
Finally, some changes were made to the docstrings
mesh.pyandsolver.pyto change math mode from Sphinx style (:math:) to markdown ($$).Validation of changes
The documentation has been built locally using
mkdocs serveon safari and chrome. The tutorial and how-tos have been tested as well (MacOS, Python 3.13)Checklist
Relevant people
@planetmariana, it would be nice, if you have time, if you could build the documentation using
mdocs serve(you might have to install some dependencies; usepip install -e ".[docs]"). Then you can check whether you agree with the content of the documentation. Additional suggestions for how-to's (e.g. troubleshooting) or tutorials (or something else) are welcome.I also added @maraattia, @timlichtenberg and @nichollsh to take a quick look if there is time.