Skip to content

Ks/docs clean#7

Merged
stuitje merged 84 commits intomainfrom
ks/docs_clean
Feb 16, 2026
Merged

Ks/docs clean#7
stuitje merged 84 commits intomainfrom
ks/docs_clean

Conversation

@stuitje
Copy link
Copy Markdown

@stuitje stuitje commented Feb 8, 2026

Description

This PR builds documentation for aragog according to the Diataxis approach. Closes FormingWorlds/PROTEUS#544.

It uses some original Sphinx documentation in ExPlanetology/aragog (converted to Markdown), but the vast majority is new. The documentation itself is divided into:

Documentation files

  • homepage (index.md)
  • Getting started (getting_started.md), shortly explains tutorials/howtos/explanations/reference and points to installation/firstrun tutorial
  • How-to's: includes an installation how-to (installation.md) and an how-to on using NetCDF output files (netcdf.md)
  • Tutorials: includes First Run tutorial (firstrun.md)
  • Explanation: includes a thorough model overview (model.md)
  • Reference: includes a list of publications (publications.md) and a full api reference making use of mkdocstrings (api.md)
  • Code of conduct: copied from proteus (CODE_OF_CONDUCT.md)

Other files

  • mkdocs.yml: the mkdocs configuration file
  • .github/workflows/docs.yaml: builds the documentation via github pages
  • docs/stylesheets/extra.css: necessary to render docstrings correctly in the api overview
  • assets/ includes PROTEUS logos
  • overrides/: a directory with a few files to force the favicon (in the browser search bar) to switch color depending on dark/light mode in chrome, safari, and firefox

source code

Finally, some changes were made to the docstrings mesh.py and solver.py to change math mode from Sphinx style (:math:) to markdown ($$).

Validation of changes

The documentation has been built locally using mkdocs serve on safari and chrome. The tutorial and how-tos have been tested as well (MacOS, Python 3.13)

Checklist

  • I have followed the contributing guidelines
  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • My changes generate no new warnings or errors
  • I have checked that the tests still pass on my computer
  • I have updated the docs, as appropriate
  • I have added tests for these changes, as appropriate
  • I have checked that all dependencies have been updated, as required

Relevant people

@planetmariana, it would be nice, if you have time, if you could build the documentation using mdocs serve (you might have to install some dependencies; use pip install -e ".[docs]"). Then you can check whether you agree with the content of the documentation. Additional suggestions for how-to's (e.g. troubleshooting) or tutorials (or something else) are welcome.

I also added @maraattia, @timlichtenberg and @nichollsh to take a quick look if there is time.

@stuitje
Copy link
Copy Markdown
Author

stuitje commented Feb 16, 2026

@nichollsh I implemented your suggestions and made a few more changes. What do you think?

@nichollsh
Copy link
Copy Markdown
Member

Looks good! I agree that writing the name as Aragog is better than as 'aragog'. The former comes across as incomplete.

@nichollsh nichollsh self-requested a review February 16, 2026 19:07
nichollsh
nichollsh previously approved these changes Feb 16, 2026
Copy link
Copy Markdown
Member

@nichollsh nichollsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please feel free to merge, @stuitje

Copy link
Copy Markdown
Member

@timlichtenberg timlichtenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks very good, a few final suggestions, then let's merge tomorrow :>

stuitje and others added 2 commits February 16, 2026 20:27
Co-authored-by: Tim Lichtenberg <lichtenberg.tim@gmail.com>
Co-authored-by: Tim Lichtenberg <lichtenberg.tim@gmail.com>
@timlichtenberg
Copy link
Copy Markdown
Member

Rapid! Happy to re-review in a couple of minutes.

@stuitje
Copy link
Copy Markdown
Author

stuitje commented Feb 16, 2026

Rapid! Happy to re-review in a couple of minutes.

I should have covered everything now.

@timlichtenberg timlichtenberg self-requested a review February 16, 2026 20:10
Copy link
Copy Markdown
Member

@timlichtenberg timlichtenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go!

@stuitje stuitje merged commit e857b3b into main Feb 16, 2026
9 checks passed
@stuitje stuitje deleted the ks/docs_clean branch February 16, 2026 20:13
@github-project-automation github-project-automation bot moved this from In Progress to Done in PROTEUS Development Roadmap Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Build documentation for fwl-aragog

4 participants