Skip to content

fix: handle string priority values in plugin updateLoadOrder()#98

Closed
MarcosBrendonDePaula wants to merge 1 commit intomainfrom
claude/review-issues-KFXyb
Closed

fix: handle string priority values in plugin updateLoadOrder()#98
MarcosBrendonDePaula wants to merge 1 commit intomainfrom
claude/review-issues-KFXyb

Conversation

@MarcosBrendonDePaula
Copy link
Copy Markdown
Collaborator

Summary

  • Add priorityMap to convert string priority values ('highest'|'high'|'normal'|'low'|'lowest') to numeric equivalents in updateLoadOrder()
  • Previously, all string priorities were silently treated as 0 (same as no priority), making the documented feature non-functional
  • Numeric priorities continue to work as before

Test plan

  • TypeScript compiles with zero errors (bunx tsc --noEmit)
  • All 527 tests pass (27 test files, 0 failures)
  • Verify a plugin with priority: 'highest' loads before one with priority: 'lowest'

Closes #78

https://claude.ai/code/session_013SuTCMwGbVm2sR7bnC5yw1

The priority field accepts strings ('highest'|'high'|'normal'|'low'|'lowest')
but updateLoadOrder() only processed numbers, treating all string priorities
as 0. Add a priority map to convert string values to numeric equivalents.

Closes #78

https://claude.ai/code/session_013SuTCMwGbVm2sR7bnC5yw1
@MarcosBrendonDePaula
Copy link
Copy Markdown
Collaborator Author

Fechando — mudanças já contempladas na main

Após revisão, todas as alterações desta branch já foram corrigidas de forma diferente (e melhor) na main:

  1. String priority nos plugins — já resolvido em 8e484f5 (Corrigir parsing de priority string no updateLoadOrder() #78) com PRIORITY_MAP/normalizePriority adequados
  2. Null guard do liveServer — já resolvido em ba69515 (Corrigir Proxy sobre null em Live Components compat layer #85) com requireLiveServer(). Esta branch removia o guard e usava liveServer!, o que causaria crash em runtime
  3. Classe FluxStackFramework duplicada — já eliminada em 7beb991 (Eliminar classe FluxStackFramework duplicada #74). Esta branch reintroduzia a duplicata
  4. Import do createHash — já corrigido em da08be9 para ESM. Esta branch revertia para require('crypto') e recolocava Content-Length hardcoded
  5. Testes do compat guard — esta branch deletava live-compat-guard.test.ts que foi adicionado na main em 9ebb129

Nenhuma mudança aqui é aproveitável. Fechando sem merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Corrigir parsing de priority string no updateLoadOrder()

2 participants