fix: add null guard for liveServer in Live Components compat layer#97
Merged
MarcosBrendonDePaula merged 2 commits intomainfrom Mar 14, 2026
Merged
Conversation
Replace unsafe non-null assertions (liveServer!) with a requireLiveServer() helper that throws a descriptive error when the LiveComponents plugin has not been initialized yet. This prevents opaque runtime crashes when compat singletons are accessed before plugin setup. Closes #85 https://claude.ai/code/session_01SSpighMyBxnrVh35Ke2Szm
12 tests covering: - All 8 Proxy singletons throw descriptive error when liveServer is null - liveAuthManager getters throw descriptive error when uninitialized - liveAuthManager.register() buffers providers when liveServer is null - Proxy delegates correctly when liveServer is initialized - liveAuthManager.register() delegates to liveServer.useAuth when initialized https://claude.ai/code/session_01SSpighMyBxnrVh35Ke2Szm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
liveServer!non-null assertions with arequireLiveServer()helper that throws a clear error message when the LiveComponents plugin hasn't been initialized yetcomponentRegistry,connectionManager,liveRoomManager,roomEvents,fileUploadManager,performanceMonitor,stateSignature,roomState, andliveAuthManagergettersError('LiveComponents plugin not initialized. Ensure the live-components plugin is loaded before accessing Live singletons.')Closes #85
Test plan
https://claude.ai/code/session_01SSpighMyBxnrVh35Ke2Szm