improve file serving: security headers, config usage, caching, and filename sanitization#60
Closed
MarcosBrendonDePaula wants to merge 1 commit intomainfrom
Closed
Conversation
…lename sanitization - static-files-plugin: use pluginsConfig values instead of hardcoded paths, add ETag headers, X-Content-Type-Options: nosniff, differentiate cache strategy for hashed assets vs uploads, force download for dangerous MIME types, respect enablePublic/enableUploads config flags - vite plugin: serve pre-compressed .gz files when Accept-Encoding allows, fix SPA fallback to use no-cache (ensures new deploys are picked up), stream proxy responses instead of buffering in memory, fix collectFiles to fail explicitly when directory is missing instead of swallowing errors - FileUploadManager: add filename sanitization (strips control chars, path separators, shell-unsafe chars), validate fileSize > 0, make cleanup interval stoppable via dispose() and unref() to avoid leaking in tests https://claude.ai/code/session_014rUaD4y9i3bB7RxYpK9S1U
MarcosBrendonDePaula
deleted the
claude/review-fluxstack-file-serving-St6Z0
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
static-files-plugin: use pluginsConfig values instead of hardcoded paths,
add ETag headers, X-Content-Type-Options: nosniff, differentiate cache
strategy for hashed assets vs uploads, force download for dangerous MIME
types, respect enablePublic/enableUploads config flags
vite plugin: serve pre-compressed .gz files when Accept-Encoding allows,
fix SPA fallback to use no-cache (ensures new deploys are picked up),
stream proxy responses instead of buffering in memory, fix collectFiles
to fail explicitly when directory is missing instead of swallowing errors
FileUploadManager: add filename sanitization (strips control chars, path
separators, shell-unsafe chars), validate fileSize > 0, make cleanup
interval stoppable via dispose() and unref() to avoid leaking in tests
https://claude.ai/code/session_014rUaD4y9i3bB7RxYpK9S1U