refactor: clean deprecated exports (#84)#106
Open
MarcosBrendonDePaula wants to merge 1 commit intomainfrom
Open
refactor: clean deprecated exports (#84)#106MarcosBrendonDePaula wants to merge 1 commit intomainfrom
MarcosBrendonDePaula wants to merge 1 commit intomainfrom
Conversation
…ry, singletons) Closes #84 - Remove all deprecated lazy proxy singletons from core/server/live/index.ts (componentRegistry, connectionManager, liveRoomManager, roomEvents, fileUploadManager, performanceMonitor, stateSignature, roomState, liveAuthManager) - Add registerAuthProvider() as clean replacement for liveAuthManager.register() - Migrate app/server/index.ts to use registerAuthProvider() - Migrate app/server/routes/room.routes.ts to use liveServer.roomManager/roomEvents - Migrate core/framework/server.ts to use liveServer.registry - Migrate plugins/crypto-auth to use registerAuthProvider() - Remove pluginDiscovery singleton export from core/index.ts and core/plugins/index.ts - Remove staticPlugin re-export from core/server/index.ts - Update tests to match new exports Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
componentRegistry,liveAuthManager,liveRoomManager,roomEvents, etc.) fromcore/server/live/index.tsregisterAuthProvider()as clean replacement forliveAuthManager.register()liveServer.*directly orregisterAuthProvider()pluginDiscoverysingleton andstaticPluginre-exportsCloses #84
Changes
core/server/live/index.tsapp/server/index.tsliveAuthManager.register()→registerAuthProvider()app/server/routes/room.routes.tsliveRoomManager/roomEvents→liveServer.roomManager/roomEventscore/framework/server.tscomponentRegistry→liveServer?.registryplugins/crypto-auth/index.tsliveAuthManager.register()→registerAuthProvider()core/index.ts+core/plugins/index.tspluginDiscoveryexportcore/server/index.tsstaticPlugin+componentRegistryre-exportstests/unit/core/live-compat-guard.test.tsregisterAuthProvider()Test plan
bun run devstarts correctly🤖 Generated with Claude Code