fix: call apply() instead of transform() in transformNegatedConstraint

[javier-godoy]

Close #109

Summary by CodeRabbit

• Bug Fixes
  • Enhanced constraint handling logic to properly process negated constraints in backend operations.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 40cd391a-15e0-4997-88c9-88d8971a0f5b

📥 Commits

Reviewing files that changed from the base of the PR and between 39116c3 and 96fc8b5.

📒 Files selected for processing (1)

• backend-core-data-impl/src/main/java/com/flowingcode/backendcore/dao/jpa/ConstraintTransformerJpaImpl.java

---

Walkthrough

Modified ConstraintTransformerJpaImpl to call apply() instead of transform() when building negated predicates. This ensures unsupported constraints throw a proper ConstraintTransformerException rather than causing a NullPointerException when transform() returns null.

Changes

Cohort / File(s)	Summary
Error handling in constraint negation backend-core-data-impl/src/main/java/com/flowingcode/backendcore/dao/jpa/ConstraintTransformerJpaImpl.java	Changed transformNegatedConstraint to invoke apply(c.getConstraint()) instead of transform(c.getConstraint()), ensuring unsupported constraints trigger descriptive exception handling rather than null reference propagation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: replacing transform() with apply() in transformNegatedConstraint method.
Linked Issues check	✅ Passed	The change directly addresses issue #109 by replacing transform() with apply() in transformNegatedConstraint to throw ConstraintTransformerException instead of NullPointerException for unsupported constraints.
Out of Scope Changes check	✅ Passed	The change is narrowly focused on fixing the specific issue in transformNegatedConstraint with a single method call replacement, containing no out-of-scope modifications.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix-109

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

You can get early access to new features in CodeRabbit.

Enable the early_access setting to enable early access features such as new models, tools, and more.

[mlopezFC]

LGTM