Skip to content

ci: add jakarta.servlet-api to v25 profile#31

Merged
paodb merged 1 commit intomasterfrom
fix/v25-jakarta-servlet-api
Mar 25, 2026
Merged

ci: add jakarta.servlet-api to v25 profile#31
paodb merged 1 commit intomasterfrom
fix/v25-jakarta-servlet-api

Conversation

@javier-godoy
Copy link
Member

@javier-godoy javier-godoy commented Mar 22, 2026

Close #30

Summary by CodeRabbit

  • Chores
    • Added test framework dependency to the v25 profile. This enhancement improves testing infrastructure support and provides better compatibility for test execution and validation scenarios.

@coderabbitai
Copy link

coderabbitai bot commented Mar 22, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 13821dc5-6dab-416b-a5fb-632bbdb92d2a

📥 Commits

Reviewing files that changed from the base of the PR and between eebbcea and 2f69579.

📒 Files selected for processing (1)
  • pom.xml

Walkthrough

Added an explicit test-scoped dependency on jakarta.servlet:jakarta.servlet-api:6.1.0 to the v25 Maven profile in pom.xml. This resolves missing servlet API classes that were previously provided transitively but dropped in newer Vaadin versions.

Changes

Cohort / File(s) Summary
Test Dependency Configuration
pom.xml
Added jakarta.servlet:jakarta.servlet-api:6.1.0 with test scope to the v25 profile to resolve missing servlet classes at runtime during testing.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related issues

  • SerializationTest fails with Vaadin 25.1 due to missing jakarta.servlet-api #30: SerializationTest fails with Vaadin 25.1 due to missing jakarta.servlet-api — This PR directly implements the exact fix specified in the linked issue to restore jakarta.servlet classes needed by serialization tests.

  • YearMonthCalendarAddon#117 — Applies the same test-scoped jakarta.servlet:jakarta.servlet-api:6.1.0 dependency fix to the v25 profile to resolve identical test failures.

  • DayOfWeekSelectorAddon#22 — Adds the same test-scoped jakarta servlet dependency to the v25 profile to fix missing servlet classes in tests.

  • ExtendedLoginAddon#30 — Implements the identical fix by adding test-scoped jakarta.servlet:jakarta.servlet-api:6.1.0 to the v25 profile.

  • MarkdownEditor#29 — Adds the same test-scoped jakarta servlet dependency to the v25 profile to restore missing Jakarta Servlet classes.

  • BadgeList#35 — Modifies the v25 profile in pom.xml with the same test-scoped jakarta.servlet:jakarta.servlet-api:6.1.0 dependency addition.

  • ChatAssistant#60 — Applies the identical test-scoped servlet API dependency fix to the v25 Maven profile.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding jakarta.servlet-api to the v25 profile as shown in the pom.xml diff.
Linked Issues check ✅ Passed The PR successfully addresses issue #30 by adding the jakarta.servlet-api:6.1.0 dependency to the v25 profile as a test-scoped dependency, resolving the SerializationTest failure.
Out of Scope Changes check ✅ Passed All changes are directly related to fixing the linked issue; only the jakarta.servlet-api dependency was added to the v25 profile with no extraneous modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/v25-jakarta-servlet-api

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@javier-godoy javier-godoy requested review from mlopezFC and paodb March 22, 2026 15:43
@sonarqubecloud
Copy link

@javier-godoy
Copy link
Member Author

@coderabbitai review

@coderabbitai
Copy link

coderabbitai bot commented Mar 22, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@javier-godoy
Copy link
Member Author

@coderabbitai review

@coderabbitai
Copy link

coderabbitai bot commented Mar 22, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@javier-godoy javier-godoy marked this pull request as ready for review March 22, 2026 17:35
@paodb paodb merged commit c2be62b into master Mar 25, 2026
5 checks passed
@paodb paodb deleted the fix/v25-jakarta-servlet-api branch March 25, 2026 12:42
@github-project-automation github-project-automation bot moved this from To Do to Pending release in Flowing Code Addons Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Pending release

Development

Successfully merging this pull request may close these issues.

SerializationTest fails with Vaadin 25.1 due to missing jakarta.servlet-api

2 participants