Refactoring GRS with Ensemble Score#10
Draft
coreen-mullen wants to merge 1 commit intoFitSNAP:developfrom
Draft
Conversation
mitwood
reviewed
Oct 7, 2025
| print("Get ensemble called.") | ||
| print("Using elems:", elems) | ||
| scores = None | ||
| try: |
Member
There was a problem hiding this comment.
These options will need to be moved out of GRS.py. Use the io method and tis sections to append the settings you need, and use the other ones that are already defined.
mitwood
reviewed
Oct 7, 2025
| #Sub-classes of Scoring will be versions of this representation loss function (Moments, Entropy, etc), allowing | ||
| #for custom verions to be added without trouble. | ||
|
|
||
| n_totconfig = 10 |
Member
There was a problem hiding this comment.
Dont want to bury inputs deep in the code, use the io method and pass the read in config to the functions that need it.
Author
|
I converted this PR into a draft, it appears that there is an implementation for the multiple structure score. I will update this pull request in the future as a place to add to the example/ folder. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are intending to add the ability to get the score of multiple structures in the refactored version of the code.