Open
Conversation
2roy999
requested changes
Sep 26, 2019
Member
2roy999
left a comment
2roy999
left a comment
There was a problem hiding this comment.
We are also missing a path in `server.js
src/main/configurator/index.js
Outdated
| const mkdirpAsync = Promise.promisify(mkdirp) | ||
|
|
||
| const STORAGE_PATH = exports.STORAGE_PATH = path.resolve('./data/$config.sqlite') | ||
| const STORAGE_PATH = exports.STORAGE_PATH = path.resolve(app.getPath('userData'), '$config.sqlite') |
Member
There was a problem hiding this comment.
We need to add our own folder fll-TMS or something like that
Member
Author
There was a problem hiding this comment.
Do I shuold use mkdir, right? Where should I do it?
src/main/mongo.js
Outdated
| const MONGO_BIN_DIR = path.resolve(`./internals/mongo/bin`) | ||
| const MONGO_EXECUTABLE_PATH = path.resolve(MONGO_BIN_DIR, `mongod${FILE_EXTENSION}`) | ||
| const MONGO_ARGUMENTS = ['--dbpath', './data/$mongo'] | ||
| const MONGO_ARGUMENTS = ['--dbpath', path.resolve(app.getPath('userData'), '$mongo')] |
Member
Author
|
@2roy999 can this be merged? |
Contributor
|
@idanstark42 I want to wait till the 1st official release is done. |
Member
|
Does it work well in Windows? Because it's broken on macOS. |
Contributor
|
yes it does, but I'll check again in the morning
…On Fri, 1 Nov 2019 at 21:54, Ofek Ashery ***@***.***> wrote:
Does it work well in Windows? Because it's broken on macOS.
[image: image]
<https://user-images.githubusercontent.com/16443111/68052264-f50b7f00-fcf1-11e9-819f-a9576c7b4737.png>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#161?email_source=notifications&email_token=ABTRZDONHORPHUAJWT4OUTDQRSCORA5CNFSM4I2RXOKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC37ZWI#issuecomment-548928729>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABTRZDLG7JTRAJGJPNGPOU3QRSCORANCNFSM4I2RXOKA>
.
--
Go green - keep it on the screen
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.