Various fixes for CodeChecker warnings

src/burp/burp.h

@@ -708,6 +708,7 @@ enum att_type {
 // Trigger types
 
 enum trig_t {
+	trig_none = 0,
 	trig_pre_store = 1,   // default
 	trig_pre_modify,	  // default
 	trig_post_erase	   // default

src/burp/restore.epp

@@ -1602,7 +1602,7 @@ bool get_acl(BurpGlobals* tdgbl, const TEXT* owner_nm, ISC_QUAD* blob_id, ISC_QU
 
 	ULONG length = 0;
 	UCHAR item;
-	USHORT max_segment;
+	USHORT max_segment = 0;
 	ULONG num_segments;
 	const UCHAR* p = blob_info;
 
@@ -1777,7 +1777,7 @@ void get_array(BurpGlobals* tdgbl, burp_rel* relation, UCHAR* record_buffer)
 	SLONG		fld_ranges[2 * MAX_DIMENSION];
 	SLONG       slice_length = 0;
 	SLONG       *range;
-	const SLONG* end_ranges;
+	const SLONG* end_ranges = nullptr;
 	scan_attr_t scan_next_attr;
 	skip_init(&scan_next_attr);
 	att_type	attribute;
@@ -1843,7 +1843,7 @@ void get_array(BurpGlobals* tdgbl, burp_rel* relation, UCHAR* record_buffer)
 	SLONG last_element_dim[MAX_DIMENSION];
 	if (return_length != slice_length)
 	{
-		int upper, lower;
+		int upper = 0, lower = 0;
 		//
 		// Ugh!  The full array wasn't returned and versions of gbak prior to
 		// V3.2I don't explicitly signal this.  We must recompute the top
@@ -3375,7 +3375,7 @@ void get_data(BurpGlobals* tdgbl, burp_rel* relation, WriteRelationReq* req)
 					}
 				}
 
-				UCHAR* p;
+				UCHAR* p = nullptr;
 				if (tdgbl->gbl_sw_transportable)
 				{
 					if (get(tdgbl) != att_xdr_length)
@@ -9078,7 +9078,7 @@ bool get_db_creator(BurpGlobals* tdgbl)
 	att_type		attribute;
 	scan_attr_t		scan_next_attr;
 	TEXT			usr[GDS_NAME_LEN];
-	SSHORT			uType;
+	SSHORT			uType = 0;
 	bool			userSet, typeSet;
 
 	userSet = typeSet = false;
@@ -9401,7 +9401,7 @@ bool get_trigger_old (BurpGlobals* tdgbl, burp_rel* relation)
  *	Get a trigger definition for a relation.
  *
  **************************************/
-	enum trig_t	type;
+	enum trig_t	type = trig_none;
 	att_type	attribute;
 	TEXT		name[GDS_NAME_LEN];
 	scan_attr_t		scan_next_attr;

src/common/CvtFormat.cpp

@@ -1347,7 +1347,7 @@ namespace
 					break;
 			}
 			if (strOffset >= strLength)
-				cb->err(Arg::Gds(isc_data_for_format_is_exhausted) << string(it->patternStr.data()));
+				cb->err(Arg::Gds(isc_data_for_format_is_exhausted) << string(it->patternStr.data(), it->patternStr.length()));
 
 			std::string_view patternStr = it->patternStr;
 

src/common/DynamicStrings.cpp

@@ -87,6 +87,8 @@ unsigned makeDynamicStrings(unsigned length, ISC_STATUS* const dst, const ISC_ST
 		case isc_arg_cstring:
 			fb_assert(string);
 			*to++ = (ISC_STATUS)(IPTR) string;
+			if (!string)
+				break;
 			memcpy(string, reinterpret_cast<const char*>(from[1]), from[0]);
 			string += *from++;
 			*string++ = '\0';
@@ -97,6 +99,8 @@ unsigned makeDynamicStrings(unsigned length, ISC_STATUS* const dst, const ISC_ST
 		case isc_arg_sql_state:
 			fb_assert(string);
 			*to++ = (ISC_STATUS)(IPTR) string;
+			if (!string)
+				break;
 			strcpy(string, reinterpret_cast<const char*>(*from));
 			string += strlen(string);
 			string++;

src/common/StatusArg.cpp

@@ -64,7 +64,7 @@ StatusVector::ImplStatusVector::ImplStatusVector(const ISC_STATUS* s) noexcept
 {
 	fb_assert(s);
 
-	clear();
+	ImplStatusVector::clear();
 
 	// special case - empty initialized status vector, no warnings
 	if (s[0] != isc_arg_gds || s[1] != 0 || s[2] != 0)
@@ -78,7 +78,7 @@ StatusVector::ImplStatusVector::ImplStatusVector(const IStatus* s) noexcept
 {
 	fb_assert(s);
 
-	clear();
+	ImplStatusVector::clear();
 
 	if (s->getState() & IStatus::STATE_ERRORS)
 		append(s->getErrors());
@@ -91,9 +91,9 @@ StatusVector::ImplStatusVector::ImplStatusVector(const Exception& ex) noexcept
 	  m_status_vector(*getDefaultMemoryPool()),
 	  m_strings(*getDefaultMemoryPool())
 {
-	clear();
+	ImplStatusVector::clear();
 
-	assign(ex);
+	ImplStatusVector::assign(ex);
 }
 
 StatusVector::StatusVector(ISC_STATUS k, ISC_STATUS c) :
@@ -143,7 +143,7 @@ void StatusVector::ImplStatusVector::assign(const StatusVector& v) noexcept
 
 void StatusVector::ImplStatusVector::assign(const Exception& ex) noexcept
 {
-	clear();
+	ImplStatusVector::clear();
 	ex.stuffException(m_status_vector);
 	putStrArg(0);
 }
@@ -263,7 +263,7 @@ bool StatusVector::ImplStatusVector::append(const ISC_STATUS* const from, const
 	if (!count)
 		return true; // not sure it's the best option here
 
-	unsigned lenBefore = length();
+	unsigned lenBefore = ImplStatusVector::length();
 	ISC_STATUS* s = m_status_vector.getBuffer(lenBefore + count + 1);
 	unsigned int copied =
 		fb_utils::copyStatus(&s[lenBefore], count + 1, from, count);
@@ -273,7 +273,7 @@ bool StatusVector::ImplStatusVector::append(const ISC_STATUS* const from, const
 
 	if (!m_warning)
 	{
-		for (unsigned n = 0; n < length(); )
+		for (unsigned n = 0; n < ImplStatusVector::length(); )
 		{
 			if (m_status_vector[n] == isc_arg_warning)
 			{
@@ -407,19 +407,25 @@ Num::Num(ISC_STATUS s) noexcept :
 Int64::Int64(SINT64 val) noexcept :
 	Str(text)
 {
-	snprintf(text, sizeof(text), "%" SQUADFORMAT, val);
+	[[maybe_unused]] auto result = snprintf(text, sizeof(text), "%" SQUADFORMAT, val);
+	fb_assert(result >= 0);
 }
 
 Int64::Int64(FB_UINT64 val) noexcept :
 	Str(text)
 {
-	snprintf(text, sizeof(text), "%" UQUADFORMAT, val);
+	[[maybe_unused]] auto result = snprintf(text, sizeof(text), "%" UQUADFORMAT, val);
+	fb_assert(result >= 0);
 }
 
 Quad::Quad(const ISC_QUAD* quad) noexcept :
 	Str(text)
 {
-	snprintf(text, sizeof(text), "%x:%x", quad->gds_quad_high, quad->gds_quad_low);
+	[[maybe_unused]] auto result = snprintf(text, sizeof(text), "%x:%x",
+		static_cast<unsigned int>(quad->gds_quad_high),
+		quad->gds_quad_low
+	);
+	fb_assert(result >= 0);
 }
 
 Interpreted::Interpreted(const char* text) noexcept :

src/common/StatusArg.h

@@ -70,8 +70,8 @@ class Base
 		virtual void clear() noexcept { }
 		virtual void append(const StatusVector&) noexcept { }
 		virtual void prepend(const StatusVector&) noexcept { }
-		virtual void assign(const StatusVector& ex) noexcept { }
-		virtual void assign(const Exception& ex) noexcept { }
+		virtual void assign(const StatusVector&) noexcept { }
+		virtual void assign(const Exception&) noexcept { }
 		virtual ISC_STATUS copyTo(ISC_STATUS*) const noexcept { return 0; }
 		virtual void copyTo(IStatus*) const noexcept { }
 		virtual void appendTo(IStatus*) const noexcept { }
@@ -145,7 +145,7 @@ class StatusVector : public Base
 			  m_status_vector(*getDefaultMemoryPool()),
 			  m_strings(*getDefaultMemoryPool())
 		{
-			clear();
+			ImplStatusVector::clear();
 		}
 
 		explicit ImplStatusVector(const ISC_STATUS* s) noexcept;

src/common/classes/NoThrowTimeStamp.cpp

@@ -341,51 +341,36 @@ int NoThrowTimeStamp::convertGregorianDateToWeekDate(const struct tm& times) noe
 {
 	// Algorithm for Converting Gregorian Dates to ISO 8601 Week Date by Rick McCarty, 1999
 	// http://personal.ecu.edu/mccartyr/ISOwdALG.txt
-
 	const int y = times.tm_year + 1900;
-	const int dayOfYearNumber = times.tm_yday + 1;
+	const int dayOfYear = times.tm_yday + 1;
 
 	// Find the jan1Weekday for y (Monday=1, Sunday=7)
-	const int yy = (y - 1) % 100;
-	const int c = (y - 1) - yy;
-	const int g = yy + yy / 4;
-	const int jan1Weekday = 1 + (((((c / 100) % 4) * 5) + g) % 7);
+	const int y_1 = y - 1;
+	const int yy = y_1 % 100;
+	const int c = y_1 - yy;
+	const int g = yy + (yy >> 2);
+	const int jan1Weekday = 1 + (((((c / 100) & 3) * 5) + g) % 7);
 
-	// Find the weekday for y m d
-	const int h = dayOfYearNumber + (jan1Weekday - 1);
-	const int weekday = 1 + ((h - 1) % 7);
+	const int weekday = 1 + ((dayOfYear + jan1Weekday - 2) % 7);
 
 	// Find if y m d falls in yearNumber y-1, weekNumber 52 or 53
-	int yearNumber, weekNumber;
-
-	if ((dayOfYearNumber <= (8 - jan1Weekday)) && (jan1Weekday > 4))
+	if ((dayOfYear <= (8 - jan1Weekday)) & (jan1Weekday > 4))
 	{
-		yearNumber = y - 1;
-		weekNumber = ((jan1Weekday == 5) || ((jan1Weekday == 6) &&
-			isLeapYear(yearNumber))) ? 53 : 52;
+		const int prevYearLeap = (!(y_1 & 3) && ((y_1 % 100) || !(y_1 % 400)));
+		const int is53 = (jan1Weekday == 5) | ((jan1Weekday == 6) & prevYearLeap);
+		return 52 + is53;
 	}
-	else
-	{
-		yearNumber = y;
 
-		// Find if y m d falls in yearNumber y+1, weekNumber 1
-		const int i = isLeapYear(y) ? 366 : 365;
-
-		if ((i - dayOfYearNumber) < (4 - weekday))
-		{
-			yearNumber = y + 1;
-			weekNumber = 1;
-		}
+	// Find if y m d falls in yearNumber y+1, weekNumber 1
+	const int daysInYear = 365 + (!(y & 3) && ((y % 100) || !(y % 400)));
+	if ((daysInYear - dayOfYear) < (4 - weekday))
+	{
+		return 1;
 	}
 
 	// Find if y m d falls in yearNumber y, weekNumber 1 through 53
-	if (yearNumber == y)
-	{
-		const int j = dayOfYearNumber + (7 - weekday) + (jan1Weekday - 1);
-		weekNumber = j / 7;
-		if (jan1Weekday > 4)
-			weekNumber--;
-	}
+	const int j = dayOfYear + (7 - weekday) + (jan1Weekday - 1);
+	const int weekNumber = (j / 7) - (jan1Weekday > 4); // Subtract 1 if jan1Weekday > 4
 
 	return weekNumber;
 }

src/common/cvt.cpp

@@ -1433,7 +1433,7 @@ double CVT_get_double(const dsc* desc, DecimalStatus decSt, ErrorFunction err, b
  *      Convert something arbitrary to a double precision number
  *
  **************************************/
-	double value;
+	double value = 0.0;
 
 	switch (desc->dsc_dtype)
 	{

src/common/isc_sync.cpp

@@ -1473,7 +1473,7 @@ SharedMemoryBase::SharedMemoryBase(const TEXT* filename, ULONG length, IpcObject
 #endif
 #endif
 
-				memset(sh_mem_mutex->mtx_mutex, 0, sizeof(*(sh_mem_mutex->mtx_mutex)));
+				memset(sh_mem_mutex->mtx_mutex, 0, sizeof(sh_mem_mutex->mtx_mutex));
 				//int state = LOG_PTHREAD_ERROR(pthread_mutex_init(sh_mem_mutex->mtx_mutex, &mattr));
 				state = pthread_mutex_init(sh_mem_mutex->mtx_mutex, &mattr);
 

src/common/unicode_util.cpp

@@ -1853,7 +1853,7 @@ USHORT UnicodeUtil::Utf16Collation::stringToKey(USHORT srcLen, const USHORT* src
 				if (keys)
 				{
 					UCHAR lastCharKey[BUFFER_TINY];	// sort key for a single character
-					ULONG prefixLen, lastCharKeyLen;
+					ULONG prefixLen = 0, lastCharKeyLen = 0;
 
 					srcLenLong -= i;
 
@@ -1877,8 +1877,6 @@ USHORT UnicodeUtil::Utf16Collation::stringToKey(USHORT srcLen, const USHORT* src
 						fb_assert(lastCharKey[lastCharKeyLen - 1] == '\0');
 						--lastCharKeyLen;
 					}
-					else
-						prefixLen = 0;
 
 					bool fallbackToPrefixKey = false;
 

src/dsql/DdlNodes.epp

@@ -216,7 +216,8 @@ static void checkForeignKeyTempScope(thread_db* tdbb, jrd_tra* transaction,
 {
 	AutoCacheRequest request(tdbb, drq_l_rel_info, DYN_REQUESTS);
 	QualifiedName masterRelName;
-	rel_t masterType, childType;
+	rel_t masterType = rel_persistent;
+	rel_t childType = rel_persistent;
 
 	FOR(REQUEST_HANDLE request TRANSACTION_HANDLE transaction)
 		RLC_M IN RDB$RELATION_CONSTRAINTS CROSS
@@ -402,7 +403,7 @@ void defineComputed(DsqlCompilerScratch* dsqlScratch, RelationSourceNode* relati
 	// Save the size of the field if it is specified.
 	dsc saveDesc;
 	saveDesc.dsc_dtype = 0;
-	bool saveCharSetIdSpecified;
+	bool saveCharSetIdSpecified = false;
 
 	if (field && field->dtype)
 	{

src/dsql/StmtNodes.cpp

@@ -523,7 +523,7 @@ BlockNode* BlockNode::pass2(thread_db* tdbb, CompilerScratch* csb)
 const StmtNode* BlockNode::execute(thread_db* tdbb, Request* request, ExeState* exeState) const
 {
 	jrd_tra* transaction = request->req_transaction;
-	SavNumber savNumber;
+	SavNumber savNumber = 0;
 
 	switch (request->req_operation)
 	{
@@ -2494,7 +2494,7 @@ void EraseNode::pass1Erase(thread_db* tdbb, CompilerScratch* csb, EraseNode* nod
 
 	jrd_rel* parent = NULL;
 	jrd_rel* view = NULL;
-	StreamType parentStream;
+	StreamType parentStream = 0;
 
 	for (;;)
 	{
@@ -5173,7 +5173,6 @@ void ExecBlockNode::genBlr(DsqlCompilerScratch* dsqlScratch)
 	{
 		inputStart = dsqlScratch->variables.getCount();
 		dsqlScratch->genParameters(parameters, returns);
-		returnsPos = dsqlScratch->variables.getCount() - dsqlScratch->outputVariables.getCount();
 	}
 
 	if (parameters.hasData())
@@ -5188,6 +5187,8 @@ void ExecBlockNode::genBlr(DsqlCompilerScratch* dsqlScratch)
 	{
 		// This validation is needed only for subroutines. Standard EXECUTE BLOCK moves input
 		// parameters to variables and are then validated.
+		// Number of input parameters to validate (total variables minus output variables)
+		const unsigned returnsPos = dsqlScratch->variables.getCount() - dsqlScratch->outputVariables.getCount();
 
 		for (unsigned i = inputStart; i < returnsPos; ++i)
 		{
@@ -8035,7 +8036,7 @@ void ModifyNode::pass1Modify(thread_db* tdbb, CompilerScratch* csb, ModifyNode*
 
 	jrd_rel* parent = NULL;
 	jrd_rel* view = NULL;
-	StreamType parentStream, parentNewStream;
+	StreamType parentStream = 0, parentNewStream = 0;
 
 	// To support nested views, loop until we hit a table or a view with user-defined triggers
 	// (which means no update).
@@ -9090,7 +9091,7 @@ bool StoreNode::pass1Store(thread_db* tdbb, CompilerScratch* csb, StoreNode* nod
 
 	jrd_rel* parent = NULL;
 	jrd_rel* view = NULL;
-	StreamType parentStream;
+	StreamType parentStream = 0;
 
 	// To support nested views, loop until we hit a table or a view with user-defined triggers
 	// (which means no update).
@@ -12437,7 +12438,7 @@ static void validateExpressions(thread_db* tdbb, const Array<ValidateInfo>& vali
 		if (i->boolean->execute(tdbb, request) == TriState(false))
 		{
 			// Validation error -- report result
-			const char* value;
+			const char* value = nullptr;
 			VaryStr<TEMP_STR_LENGTH> temp;
 
 			const dsc* desc = EVL_expr(tdbb, request, i->value);
@@ -12449,6 +12450,7 @@ static void validateExpressions(thread_db* tdbb, const Array<ValidateInfo>& vali
 			else if (!length)
 				value = "";
 			else
+				fb_assert(value);
 				const_cast<char*>(value)[length] = 0;	// safe cast - data is actually on the stack
 
 			string name;

src/gpre/c_cxx.cpp

@@ -2668,6 +2668,8 @@ static void gen_put_segment( const act* action, int column)
 	args.pat_ident1 = blob->blb_len_ident;
 	args.pat_ident2 = blob->blb_buff_ident;
 	args.pat_string1 = global_status_name;
+	args.pat_long1 = NULL;
+	args.pat_long2 = NULL;
 	PATTERN_expand((USHORT) column, pattern1, &args);
 
 	set_sqlcode(action, column);