Fix simulation.clear_cache() crashes#105
Open
chraibi wants to merge 3 commits intoFireDynamics:masterfrom
Open
Fix simulation.clear_cache() crashes#105chraibi wants to merge 3 commits intoFireDynamics:masterfrom
chraibi wants to merge 3 commits intoFireDynamics:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an acceptance test intended to reproduce Issue #104, where Simulation.clear_cache() crashes when the simulation includes “line DEVC” devices (expanded into lists of Device objects).
Changes:
- Update
test_devcto constructSimulationusing a path relative to the test file location. - Add a new acceptance test that calls
clear_cache()for a case containing line DEVC devices.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
chraibi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #104