Skip to content

Docs fixes#355

Merged
gkorland merged 17 commits intomainfrom
claude/update-docs-references-and-python
Mar 22, 2026
Merged

Docs fixes#355
gkorland merged 17 commits intomainfrom
claude/update-docs-references-and-python

Conversation

@Claude
Copy link
Contributor

@Claude Claude AI commented Feb 17, 2026

Original prompt

This section details on the original issue you should resolve

<issue_title>Docs fixes</issue_title>
<issue_description>

Outdated references to RedisGraph and Redis tooling

  • Files:
    • design/client-spec.md — references "RedisGraph v2.1.0", links to deprecated redisgraph-py repo
    • design/third-party.md — RedisGraph/Redis licensing may be outdated
    • getting-started/clients.md — many "Additional Clients" reference RedisGraph projects with no compatibility note
    • commands/index.md — "within Redis" phrasing may be misleading
    • operations/k8s-support.md — uses "master and slave" terminology
  • Action: Update terminology, add compatibility notes, fix links.

Update EOL Python version requirements

  • Files: operations/migration/kuzu-to-falkordb.md (Python 3.6+), operations/migration/neo4j-to-falkordb.md (Python 3.6+), operations/opentelemetry.md (Python 3.8+)
  • Action: Update to currently supported Python version (3.9+ minimum).

Fix _config.yml issues

  • Missing url key for canonical URL generation
  • Missing exclude list (README.md, Gemfile, etc. will be built into the site)
  • Unpinned remote_theme version
  • Protocol-relative URLs (//github.com/...) should use https://
  • Consider adding jekyll-seo-tag plugin
  • Ruby docs link references EOL Ruby 2.7

Standardize command page structure

  • Issue: Inconsistent formatting across command pages — some use headings for Arguments/Returns, some use inline text, some use <details> HTML.
  • Action: Adopt graph.memory.md structure (Syntax, Arguments, Return, Examples) as template for all command pages.

Standardize shell prompt style in examples

  • Issue: Varies between 127.0.0.1:6379>, redis>, >, and no prompt.
  • Action: Pick one convention and apply it consistently.

Fix inconsistent code example completeness

  • Issue: Some command examples show full imports/client setup, others show only the call.
  • Files: graph.query.md, graph.ro-query.md (no setup) vs graph.list.md, graph.config-set.md (full setup)
  • Action: Make all examples copy-paste ready with setup code.

De-duplicate Rust Loader content in migration guides

  • Files: operations/migration/kuzu-to-falkordb.md, operations/migration/neo4j-to-falkordb.md
  • Issue: The FalkorDB-Loader-RS section is nearly identical in both files.
  • Action: Extract to a shared page and reference from both.

De-duplicate content in agentic-memory/cognee.md

  • Issue: LLM config appears twice, database config appears twice, "Managing Knowledge" duplicates "Adding Multiple Documents".
  • Action: Consolidate to reduce page length by ~30%.

Reconcile cloud pricing tables

  • Files: cloud/free-tier.md, cloud/startup-tier.md, cloud/enterprise-tier.md
  • Issues: Discrepancies in Azure/BYOC notation, last-row labels ("Call-to-Action" vs "Get started"), feature highlighting
  • Action: Unify table content across all tier pages.

Fix cloud/free-tier.md heading level

  • Issue: Uses #### Terms (H4) while all other tier pages use ## Terms (H2).

Fix cloud/features.md hierarchy

  • Issue: "Solution Architecture" incorrectly nested under "Graph Browser" as H3. Should be its own H2.
  • Issue: Missing docs for Graph Access Control, Cluster Deployment, HA, Multi-zone, Automated Backups, Advanced Monitoring.

Expand commands/index.md landing page

  • Issue: Very short, does not list or link to any child command pages.
  • Action: Add a table or list of all available commands with brief descriptions.

Fix design/client-spec.md outdated claims

  • Line 192: "each node can have either 0 or 1 labels" — multi-label is now supported
  • Lines 38-40: Links to specific commit hash for enum definitions — will drift
  • Action: Update content to reflect current capabilities.

Add missing redirect_from in Cypher section

  • Files: call.md, foreach.md, merge.md, skip.md, limit.md, remove.md, match.md, procedures.md, set.md, unwind.md, where.md, with.md

Expand thin Cypher pages

  • Files: cypher/skip.md, cypher/limit.md, cypher/order-by.md
  • Action: Add edge-case docs (SKIP beyond total records, LIMIT without ORDER BY, NULL sort ordering), cross-references, and complete query examples.

Add missing Go and C# to getting-started installation tabs

  • File: getting-started/index.md
  • Issue: Both are official clients but missing from the tabbed examples.

Fix udfs/index.md structural issues

  • Line 274: falkor.register heading is H5 instead of H4
  • Line 251-253: Misplaced paragraph about multi-source traversal
  • Line 394: Grammar — missing comma and conjunction

Fix operations/opentelemetry.md scope and accuracy

  • Title doesn't indicate Python-only focus
  • RedisInstrumentor imported but never used
  • Jaeger exporter is deprecated — should note OTLP alternative
  • Only covers traces despite c...

Claude AI and others added 3 commits February 17, 2026 21:35
Co-authored-by: gkorland <753206+gkorland@users.noreply.github.com>
Co-authored-by: gkorland <753206+gkorland@users.noreply.github.com>
Co-authored-by: gkorland <753206+gkorland@users.noreply.github.com>
@Claude Claude AI changed the title [WIP] Fix outdated references and Python version requirements Fix outdated references, terminology, Python versions, and structural issues across documentation Feb 17, 2026
@Claude Claude AI requested a review from gkorland February 17, 2026 21:40
@gkorland gkorland marked this pull request as ready for review February 18, 2026 17:00
@gkorland
Copy link
Contributor

@claude[agent] please fix the spelling error

Co-authored-by: gkorland <753206+gkorland@users.noreply.github.com>
@Claude
Copy link
Contributor Author

Claude AI commented Feb 18, 2026

@claude[agent] please fix the spelling error

Fixed in 95cad33. Changed "This file specify" to "This file specifies" and "and configure" to "and configures" in operations/k8s-support.md.

@Claude Claude AI changed the title Fix outdated references, terminology, Python versions, and structural issues across documentation Addressing PR comments Feb 18, 2026
@gkorland gkorland changed the title Addressing PR comments Docs fixes Feb 24, 2026
gkorland and others added 3 commits February 24, 2026 13:28
Merge main into PR branch, resolving conflicts in:
- cloud/features.md: keep blank line after Solution Architecture heading
- cloud/free-tier.md: keep H2 Terms heading to match other tier pages
- design/client-spec.md: accept main's two-line formatting
- operations/opentelemetry.md: use concise 'Python 3.9+' phrasing
- udfs/index.md: keep falkor description paragraph, keep grammar fix

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Removed sections on Graph Access Control, Cluster Deployment, High Availability, Multi-zone Deployment, Automated Backups, and Advanced Monitoring due to pending documentation.
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates FalkorDB documentation to remove outdated RedisGraph/Redis-era references, improve site configuration, and add missing redirects and content structure fixes across docs pages.

Changes:

  • Refresh terminology and references (RedisGraph → FalkorDB) and add compatibility guidance for legacy clients.
  • Improve docs site config (canonical url, pinned theme version, SEO plugin, excludes, https links).
  • Add redirect_from entries for multiple Cypher clause pages and fix minor doc structure/wording issues.

Reviewed changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
udfs/index.md Minor wording/grammar fix in UDF example explanation.
operations/opentelemetry.md Clarifies Python tracing scope in page description/intro.
getting-started/clients.md Adds support/compatibility note for RedisGraph-origin “Additional Clients”.
design/third-party.md Reworks RedisGraph/Redis/RediSearch references into a historical attribution section.
design/client-spec.md Updates enum links away from pinned commit; replaces RedisGraph references and corrects label semantics.
cypher/call.md Adds missing redirect_from entries.
cypher/foreach.md Adds missing redirect_from entries.
cypher/limit.md Adds missing redirect_from entries.
cypher/match.md Adds missing redirect_from entries.
cypher/merge.md Adds missing redirect_from entries.
cypher/procedures.md Adds missing redirect_from entries.
cypher/remove.md Adds missing redirect_from entries.
cypher/set.md Adds missing redirect_from entries.
cypher/skip.md Adds missing redirect_from entries.
cypher/unwind.md Adds missing redirect_from entries.
cypher/where.md Adds missing redirect_from entries.
cypher/with.md Adds missing redirect_from entries.
commands/index.md Adjusts wording to avoid “within Redis” phrasing.
cloud/free-tier.md Fixes heading level for “Terms” section.
cloud/features.md Adds new feature headings for missing topics (currently placeholders).
_config.yml Pins theme version, adds canonical url, SEO plugin, excludes, and https aux links.
.wordlist.txt Adds “foreach” to spellcheck wordlist.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +39 to +41
[ColumnType](https://github.com/FalkorDB/FalkorDB/blob/master/src/resultset/formatters/resultset_formatter.h) enum, which as of v2.1.0 will always be `COLUMN_SCALAR`. This enum is retained for backwards compatibility, and may be ignored by the client unless versions older than v2.1.0 must be supported.

[ValueType](https://github.com/FalkorDB/FalkorDB/blob/ff108d7e21061025166a35d29be1a1cb5bac6d55/src/resultset/formatters/resultset_formatter.h#L21-L28) indicates the data type (such as Node, integer, or string) of each returned value. Each value is emitted as a 2-array, with this enum in the first position and the actual value in the second. Each property on a graph entity also has a scalar as its value, so this construction is nested in each value of the properties array when a column contains a node or relationship.
[ValueType](https://github.com/FalkorDB/FalkorDB/blob/master/src/resultset/formatters/resultset_formatter.h) enum indicates the data type (such as Node, integer, or string) of each returned value. Each value is emitted as a 2-array, with this enum in the first position and the actual value in the second. Each property on a graph entity also has a scalar as its value, so this construction is nested in each value of the properties array when a column contains a node or relationship.
Copy link

Copilot AI Mar 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this sentence, “as of v2.1.0” is ambiguous (v2.1.0 of what?) and later in the doc you use “FalkorDB v2.1.0”. Consider making this consistent by naming the product/version here as well (e.g., “as of FalkorDB v2.1.0”).

Copilot uses AI. Check for mistakes.

## Historical Attribution

FalkorDB is built upon technology originally developed as RedisGraph (licensed under RSALv2/SSPLv1) and Redis (licensed under RSALv2/SSPLv1), and RediSearch (licensed under RSALv2/SSPLv1). FalkorDB continues to evolve these technologies under an open-source model.
Copy link

Copilot AI Mar 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new “Historical Attribution” paragraph mentions RSALv2/SSPLv1 but no longer links to the license texts (the previous numbered entries did). To keep this section verifiable and avoid ambiguity, add links to the referenced licenses (and/or the relevant upstream repos’ LICENSE files) in this paragraph.

Suggested change
FalkorDB is built upon technology originally developed as RedisGraph (licensed under RSALv2/SSPLv1) and Redis (licensed under RSALv2/SSPLv1), and RediSearch (licensed under RSALv2/SSPLv1). FalkorDB continues to evolve these technologies under an open-source model.
FalkorDB is built upon technology originally developed as [RedisGraph](https://github.com/RedisGraph/RedisGraph) (licensed under the [Redis Source Available License v2 (RSALv2)](https://redis.com/legal/rsalv2-agreement/) / [Server Side Public License v1 (SSPLv1)](https://www.mongodb.com/licensing/server-side-public-license)), [Redis](https://github.com/redis/redis) (licensed under RSALv2/SSPLv1), and [RediSearch](https://github.com/RediSearch/RediSearch) (licensed under RSALv2/SSPLv1). FalkorDB continues to evolve these technologies under an open-source model.

Copilot uses AI. Check for mistakes.
gkorland and others added 4 commits March 22, 2026 09:05
Remove redirect_from front matter added to 12 cypher pages:
call, foreach, limit, match, merge, procedures, remove, set,
skip, unwind, where, with.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There is a newer version available than v0.10.0, so revert to
unpinned remote_theme to pick it up automatically.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Revert the Historical Attribution rewrite and restore the original
RedisGraph, Redis, and RediSearch entries. Add AGPLv3 as an
additional license option for all three.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
gkorland and others added 3 commits March 22, 2026 09:38
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Restore original commit hash links with line anchors and
redisgraph-py example references.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@gkorland gkorland merged commit df21552 into main Mar 22, 2026
3 checks passed
@gkorland gkorland deleted the claude/update-docs-references-and-python branch March 22, 2026 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs fixes

3 participants