Conversation
Co-authored-by: gkorland <753206+gkorland@users.noreply.github.com>
Co-authored-by: gkorland <753206+gkorland@users.noreply.github.com>
Co-authored-by: gkorland <753206+gkorland@users.noreply.github.com>
|
@claude[agent] please fix the spelling error |
Co-authored-by: gkorland <753206+gkorland@users.noreply.github.com>
Fixed in 95cad33. Changed "This file specify" to "This file specifies" and "and configure" to "and configures" in operations/k8s-support.md. |
Merge main into PR branch, resolving conflicts in: - cloud/features.md: keep blank line after Solution Architecture heading - cloud/free-tier.md: keep H2 Terms heading to match other tier pages - design/client-spec.md: accept main's two-line formatting - operations/opentelemetry.md: use concise 'Python 3.9+' phrasing - udfs/index.md: keep falkor description paragraph, keep grammar fix Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Removed sections on Graph Access Control, Cluster Deployment, High Availability, Multi-zone Deployment, Automated Backups, and Advanced Monitoring due to pending documentation.
There was a problem hiding this comment.
Pull request overview
This PR updates FalkorDB documentation to remove outdated RedisGraph/Redis-era references, improve site configuration, and add missing redirects and content structure fixes across docs pages.
Changes:
- Refresh terminology and references (RedisGraph → FalkorDB) and add compatibility guidance for legacy clients.
- Improve docs site config (canonical
url, pinned theme version, SEO plugin, excludes, https links). - Add
redirect_fromentries for multiple Cypher clause pages and fix minor doc structure/wording issues.
Reviewed changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| udfs/index.md | Minor wording/grammar fix in UDF example explanation. |
| operations/opentelemetry.md | Clarifies Python tracing scope in page description/intro. |
| getting-started/clients.md | Adds support/compatibility note for RedisGraph-origin “Additional Clients”. |
| design/third-party.md | Reworks RedisGraph/Redis/RediSearch references into a historical attribution section. |
| design/client-spec.md | Updates enum links away from pinned commit; replaces RedisGraph references and corrects label semantics. |
| cypher/call.md | Adds missing redirect_from entries. |
| cypher/foreach.md | Adds missing redirect_from entries. |
| cypher/limit.md | Adds missing redirect_from entries. |
| cypher/match.md | Adds missing redirect_from entries. |
| cypher/merge.md | Adds missing redirect_from entries. |
| cypher/procedures.md | Adds missing redirect_from entries. |
| cypher/remove.md | Adds missing redirect_from entries. |
| cypher/set.md | Adds missing redirect_from entries. |
| cypher/skip.md | Adds missing redirect_from entries. |
| cypher/unwind.md | Adds missing redirect_from entries. |
| cypher/where.md | Adds missing redirect_from entries. |
| cypher/with.md | Adds missing redirect_from entries. |
| commands/index.md | Adjusts wording to avoid “within Redis” phrasing. |
| cloud/free-tier.md | Fixes heading level for “Terms” section. |
| cloud/features.md | Adds new feature headings for missing topics (currently placeholders). |
| _config.yml | Pins theme version, adds canonical url, SEO plugin, excludes, and https aux links. |
| .wordlist.txt | Adds “foreach” to spellcheck wordlist. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
design/client-spec.md
Outdated
| [ColumnType](https://github.com/FalkorDB/FalkorDB/blob/master/src/resultset/formatters/resultset_formatter.h) enum, which as of v2.1.0 will always be `COLUMN_SCALAR`. This enum is retained for backwards compatibility, and may be ignored by the client unless versions older than v2.1.0 must be supported. | ||
|
|
||
| [ValueType](https://github.com/FalkorDB/FalkorDB/blob/ff108d7e21061025166a35d29be1a1cb5bac6d55/src/resultset/formatters/resultset_formatter.h#L21-L28) indicates the data type (such as Node, integer, or string) of each returned value. Each value is emitted as a 2-array, with this enum in the first position and the actual value in the second. Each property on a graph entity also has a scalar as its value, so this construction is nested in each value of the properties array when a column contains a node or relationship. | ||
| [ValueType](https://github.com/FalkorDB/FalkorDB/blob/master/src/resultset/formatters/resultset_formatter.h) enum indicates the data type (such as Node, integer, or string) of each returned value. Each value is emitted as a 2-array, with this enum in the first position and the actual value in the second. Each property on a graph entity also has a scalar as its value, so this construction is nested in each value of the properties array when a column contains a node or relationship. |
There was a problem hiding this comment.
In this sentence, “as of v2.1.0” is ambiguous (v2.1.0 of what?) and later in the doc you use “FalkorDB v2.1.0”. Consider making this consistent by naming the product/version here as well (e.g., “as of FalkorDB v2.1.0”).
design/third-party.md
Outdated
|
|
||
| ## Historical Attribution | ||
|
|
||
| FalkorDB is built upon technology originally developed as RedisGraph (licensed under RSALv2/SSPLv1) and Redis (licensed under RSALv2/SSPLv1), and RediSearch (licensed under RSALv2/SSPLv1). FalkorDB continues to evolve these technologies under an open-source model. |
There was a problem hiding this comment.
The new “Historical Attribution” paragraph mentions RSALv2/SSPLv1 but no longer links to the license texts (the previous numbered entries did). To keep this section verifiable and avoid ambiguity, add links to the referenced licenses (and/or the relevant upstream repos’ LICENSE files) in this paragraph.
| FalkorDB is built upon technology originally developed as RedisGraph (licensed under RSALv2/SSPLv1) and Redis (licensed under RSALv2/SSPLv1), and RediSearch (licensed under RSALv2/SSPLv1). FalkorDB continues to evolve these technologies under an open-source model. | |
| FalkorDB is built upon technology originally developed as [RedisGraph](https://github.com/RedisGraph/RedisGraph) (licensed under the [Redis Source Available License v2 (RSALv2)](https://redis.com/legal/rsalv2-agreement/) / [Server Side Public License v1 (SSPLv1)](https://www.mongodb.com/licensing/server-side-public-license)), [Redis](https://github.com/redis/redis) (licensed under RSALv2/SSPLv1), and [RediSearch](https://github.com/RediSearch/RediSearch) (licensed under RSALv2/SSPLv1). FalkorDB continues to evolve these technologies under an open-source model. |
Remove redirect_from front matter added to 12 cypher pages: call, foreach, limit, match, merge, procedures, remove, set, skip, unwind, where, with. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There is a newer version available than v0.10.0, so revert to unpinned remote_theme to pick it up automatically. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Revert the Historical Attribution rewrite and restore the original RedisGraph, Redis, and RediSearch entries. Add AGPLv3 as an additional license option for all three. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Restore original commit hash links with line anchors and redisgraph-py example references. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Original prompt
This section details on the original issue you should resolve
<issue_title>Docs fixes</issue_title>
<issue_description>
Outdated references to RedisGraph and Redis tooling
design/client-spec.md— references "RedisGraph v2.1.0", links to deprecatedredisgraph-pyrepodesign/third-party.md— RedisGraph/Redis licensing may be outdatedgetting-started/clients.md— many "Additional Clients" reference RedisGraph projects with no compatibility notecommands/index.md— "within Redis" phrasing may be misleadingoperations/k8s-support.md— uses "master and slave" terminologyUpdate EOL Python version requirements
operations/migration/kuzu-to-falkordb.md(Python 3.6+),operations/migration/neo4j-to-falkordb.md(Python 3.6+),operations/opentelemetry.md(Python 3.8+)Fix
_config.ymlissuesurlkey for canonical URL generationexcludelist (README.md, Gemfile, etc. will be built into the site)remote_themeversion//github.com/...) should usehttps://jekyll-seo-tagpluginStandardize command page structure
<details>HTML.graph.memory.mdstructure (Syntax, Arguments, Return, Examples) as template for all command pages.Standardize shell prompt style in examples
127.0.0.1:6379>,redis>,>, and no prompt.Fix inconsistent code example completeness
graph.query.md,graph.ro-query.md(no setup) vsgraph.list.md,graph.config-set.md(full setup)De-duplicate Rust Loader content in migration guides
operations/migration/kuzu-to-falkordb.md,operations/migration/neo4j-to-falkordb.mdDe-duplicate content in
agentic-memory/cognee.mdReconcile cloud pricing tables
cloud/free-tier.md,cloud/startup-tier.md,cloud/enterprise-tier.mdFix
cloud/free-tier.mdheading level#### Terms(H4) while all other tier pages use## Terms(H2).Fix
cloud/features.mdhierarchyExpand
commands/index.mdlanding pageFix
design/client-spec.mdoutdated claimsAdd missing
redirect_fromin Cypher sectioncall.md,foreach.md,merge.md,skip.md,limit.md,remove.md,match.md,procedures.md,set.md,unwind.md,where.md,with.mdExpand thin Cypher pages
cypher/skip.md,cypher/limit.md,cypher/order-by.mdAdd missing Go and C# to getting-started installation tabs
getting-started/index.mdFix
udfs/index.mdstructural issuesfalkor.registerheading is H5 instead of H4Fix
operations/opentelemetry.mdscope and accuracyRedisInstrumentorimported but never used