Skip to content

feat: restore menu button and filter menu items to red-box items only #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
YangYue128-helen merged 1 commit into from
Mar 10, 2026
Merged

feat: restore menu button and filter menu items to red-box items only #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions frontend/src/components/editor/actions/useNotebookActions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,13 +463,15 @@ export function useNotebookActions() {
icon: <CommandIcon size={14} strokeWidth={1.5} />,
label: "Command palette",
hotkey: "global.commandPalette",
redundant: true,
handle: () => setCommandPaletteOpen((open) => !open),
},

{
icon: <KeyboardIcon size={14} strokeWidth={1.5} />,
label: "Keyboard shortcuts",
hotkey: "global.showHelp",
redundant: true,
handle: () => setKeyboardShortcutsOpen((open) => !open),
},
{
Expand All @@ -481,6 +483,7 @@ export function useNotebookActions() {
{
icon: <ExternalLinkIcon size={14} strokeWidth={1.5} />,
label: "Resources",
redundant: true,
handle: NOOP_HANDLER,
dropdown: [
{
Expand Down Expand Up @@ -528,6 +531,7 @@ export function useNotebookActions() {
// If file is in the url, then we ran `marimo edit`
// without a specific file
hidden: !location.search.includes("file"),
redundant: true,
handle: () => {
const withoutSearch = document.baseURI.split("?")[0];
window.open(withoutSearch, "_self");
Expand All @@ -540,6 +544,7 @@ export function useNotebookActions() {
// If file is in the url, then we ran `marimo edit`
// without a specific file
hidden: !location.search.includes("file"),
redundant: true,
handle: () => {
const url = newNotebookURL();
window.open(url, "_blank");
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/components/editor/controls/Controls.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,11 +88,11 @@ export const Controls = ({
{!closed && (
<div className={topRightControls}>
{presenting && <LayoutSelect />}
{/* <NotebookMenuDropdown
<NotebookMenuDropdown
disabled={disabled}
tooltip={connectionTooltip}
/>
<ConfigButton disabled={disabled} tooltip={connectionTooltip} /> */}
{/* <ConfigButton disabled={disabled} tooltip={connectionTooltip} /> */}
<ShutdownButton
description="This will terminate the Python kernel. You'll lose all data that's in memory."
disabled={disabled}
Expand Down
Loading