Load all storage data into cache during Onyx.init by fabioh8010 · Pull Request #752 · Expensify/react-native-onyx

fabioh8010 · 2026-03-13T09:02:07Z

Details

This PR replaces Onyx's lazy per-key cache population strategy with a single bulk read of the entire storage database during init(), and removes the cache eviction system that is no longer needed.

E/App PR: Expensify/App#85210

Related Issues

Expensify/App#85252

Automated Tests

Unit tests added/changed to cover the changes.

Manual Tests

Open the app
Verify the app loaded correctly
Go offline
Send a couple of messages to anyone
Go back online
Verify the messages were synced correctly

Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

We couldn't record for Android web as emulator crashes randomly.

iOS: Native

ios.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

fabioh8010 · 2026-03-17T11:17:22Z

Reassure output

🔴 OnyxUtils initializeWithDefaultKeyStates one call initializing 10k heavy objects > Duration deviation of 137.44 ms (43.56%) exceeded the allowed range of 20.00 ms (40.00%).
🔴 Onyx init one call with 10k records to init > Duration deviation of 129.10 ms (41.26%) exceeded the allowed range of 20.00 ms (40.00%).
🟢 Onyx merge 10k calls with heavy objects > Duration deviation of -24.41 ms (-8.06%) is within the allowed range of 20.00 ms (40.00%).
🟢 OnyxUtils subscribeToKey one call subscribing to a whole collection of 10k heavy objects > Duration deviation of -143.55 ms (-91.34%) is within the allowed range of 20.00 ms (40.00%).
🟢 OnyxUtils get 10k calls with heavy objects > Duration deviation of -52.63 ms (-91.45%) is within the allowed range of 20.00 ms (40.00%).

The 🔴 are expected because of this PR very purpose – load all storage data into cache during startup.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2c251c8440

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

lib/OnyxUtils.ts

situchan · 2026-03-17T22:50:56Z

Web tests well. Mobile app testing currently blocked by this bug on main

lib/OnyxUtils.ts

JKobrynski · 2026-03-18T08:23:55Z

lib/storage/providers/SQLiteProvider.ts

+        return provider.store.executeAsync<OnyxSQLiteKeyValuePair>('SELECT record_key, valueJSON FROM keyvaluepairs;').then(({rows}) => {
+            // eslint-disable-next-line no-underscore-dangle
+            const result = rows?._array.map((row) => [row.record_key, JSON.parse(row.valueJSON)]);
+            return (result ?? []) as StorageKeyValuePair[];
+        });


You tested this on a high traffic account right? I wonder if parsing all JSON synchronously may slow the app down or even block it. It's unlikely, just worth checking imo.

I agree with the concern. Maybe you can set up some performance timing for this? I'd like to know what impact it will have on real accounts, especially the large ones.

results from dev environment with 33k keys:

web: 320ms

iOS: 700ms

It's hard to compare it 1:1 with current solution, because on main this cost is spread across the entire startup - but in general ManualAppStartup metric gets 2.5s faster for this account on iOS

lib/OnyxUtils.ts

adhorodyski

nothing more than what is already pointed out, lgtm

tgolen

This is a very large PR, so naturally, I have concerns with it. What I would suggest is to rewrite the PR to only contain the absolute bare-minimum changes necessary to introduce the cache loading on it. This would mean:

eviction code stays for now
RAM only keys stay for now

If we pre-load everything into cache, then we won't have to make any other changes initially, right? cache.hasCacheKey() would naturally return true for all the keys. At least, that's the idea anyway for the least amount of changes.

I think that will allow us to really evaluate if this change is truly a good one, or one that we want to revert. It is hard to determine it's effectiveness until it's in the real world, and then we can clean that stuff up later if we decide to keep it permanent.

tgolen · 2026-03-18T15:21:41Z

lib/storage/providers/SQLiteProvider.ts

+        return provider.store.executeAsync<OnyxSQLiteKeyValuePair>('SELECT record_key, valueJSON FROM keyvaluepairs;').then(({rows}) => {
+            // eslint-disable-next-line no-underscore-dangle
+            const result = rows?._array.map((row) => [row.record_key, JSON.parse(row.valueJSON)]);
+            return (result ?? []) as StorageKeyValuePair[];
+        });


I agree with the concern. Maybe you can set up some performance timing for this? I'd like to know what impact it will have on real accounts, especially the large ones.

lib/OnyxUtils.ts

fabioh8010 · 2026-03-20T08:27:25Z

Ready to review again @tgolen @marcaaron @Julesssss @situchan – we removed the cache eviction changes

tgolen

This looks great now, thank you! I really appreciate the verbose comments. Those are super helpful.

marcaaron

LGTM overall. Didn't have too many comments. I think we should give this a shot.

marcaaron · 2026-03-20T22:25:15Z

lib/OnyxUtils.ts

+            const allDataFromStorage: Record<string, unknown> = {};
+            for (const [key, value] of pairs) {
+                // RAM-only keys should never be loaded from storage as they may have stale persisted data
+                // from before the key was migrated to RAM-only.


nit pick - they are now being loaded from storage just not cached so the comment is stale

marcaaron · 2026-03-20T22:34:47Z

lib/OnyxUtils.ts

+                    continue;
+                }
+
+                // Skip collection members that are marked as skippable


NAB, but I went to try to understand what is a skippable collection member id and there's not really any documentation in react-native-onyx about it.

It seems like it exists to prevent the possibility of malformed collection keys which is reasonable, but I think we could document this better at the library level.

marcaaron · 2026-03-20T22:36:49Z

lib/OnyxUtils.ts

+
+            // Notify subscribers about default key states so that any subscriber that connected
+            // before init (e.g. during module load) receives the merged default values immediately
+            for (const [key, value] of Object.entries(merged ?? {})) keyChanged(key, value);


Suggested change

for (const [key, value] of Object.entries(merged ?? {})) keyChanged(key, value);

for (const [key, value] of Object.entries(merged ?? {})) {

keyChanged(key, value);

};

nab/style

marcaaron · 2026-03-20T22:38:54Z

lib/OnyxUtils.ts

+            for (const [key, value] of Object.entries(merged ?? {})) keyChanged(key, value);
+        })
+        .catch((error) => {
+            Logger.logAlert(`Failed to load data from storage during init. The app will boot with default key states only. Error: ${error}`);


We should probably keep track of this in logs somehow. I'd be very curious to see the cases where this throws and why.

marcaaron · 2026-03-20T22:45:15Z

lib/OnyxUtils.ts

+            cache.merge(merged ?? {});
+
+            // Notify subscribers about default key states so that any subscriber that connected
+            // before init (e.g. during module load) receives the merged default values immediately


Interesting. Who connects before? I guess we do not block subscriptions on init phase?

melvin-bot bot assigned fabioh8010 Mar 13, 2026

Julesssss self-requested a review March 13, 2026 16:50

Julesssss mentioned this pull request Mar 13, 2026

Load all storage data into cache on startup and remove the eviction system Expensify/App#85252

Open

marcaaron self-requested a review March 13, 2026 19:41

fabioh8010 changed the title ~~[WIP] [POC] Load all storage data into cache during Onyx.init~~ Load all storage data into cache during Onyx.init Mar 17, 2026

fabioh8010 marked this pull request as ready for review March 17, 2026 11:20

fabioh8010 requested a review from a team as a code owner March 17, 2026 11:20

melvin-bot bot removed the request for review from a team March 17, 2026 11:21

chatgpt-codex-connector bot reviewed Mar 17, 2026

View reviewed changes

lib/OnyxUtils.ts Show resolved Hide resolved

mountiny requested a review from situchan March 17, 2026 21:25

VickyStash reviewed Mar 18, 2026

View reviewed changes

lib/OnyxUtils.ts Outdated Show resolved Hide resolved

VickyStash reviewed Mar 18, 2026

View reviewed changes

lib/OnyxUtils.ts Outdated Show resolved Hide resolved

lib/OnyxUtils.ts Outdated Show resolved Hide resolved

JKobrynski reviewed Mar 18, 2026

View reviewed changes

lib/OnyxUtils.ts Show resolved Hide resolved

JKobrynski reviewed Mar 18, 2026

View reviewed changes

lib/OnyxUtils.ts Outdated Show resolved Hide resolved

adhorodyski approved these changes Mar 18, 2026

View reviewed changes

tgolen requested changes Mar 18, 2026

View reviewed changes

TMisiukiewicz force-pushed the sync-cache-2 branch from 2c251c8 to 5a0ef6d Compare March 19, 2026 08:19

Load all storage data into cache during init

fc85004

TMisiukiewicz force-pushed the sync-cache-2 branch from a2037d3 to fc85004 Compare March 19, 2026 13:00

fabioh8010 requested review from JKobrynski, VickyStash, adhorodyski and tgolen March 19, 2026 13:10

adhorodyski approved these changes Mar 20, 2026

View reviewed changes

tgolen reviewed Mar 20, 2026

View reviewed changes

marcaaron approved these changes Mar 20, 2026

View reviewed changes

Conversation

fabioh8010 commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Related Issues

Automated Tests

Manual Tests

Author Checklist

Screenshots/Videos

Uh oh!

fabioh8010 commented Mar 17, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

situchan commented Mar 17, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

adhorodyski left a comment

Choose a reason for hiding this comment

Uh oh!

tgolen left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fabioh8010 commented Mar 20, 2026

Uh oh!

tgolen left a comment

Choose a reason for hiding this comment

Uh oh!

marcaaron left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

fabioh8010 commented Mar 13, 2026 •

edited

Loading