Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request removes the unused n_tel (telescope multiplicity) parameter from the pre-cuts functions and training configuration. The parameter was previously accepted but never used in the function logic, as the models now handle all telescope multiplicities in a single model rather than training separate models per multiplicity.
Changes:
- Removed
n_telparameter frompre_cuts_regression()andpre_cuts_classification()functions - Removed
--n_telCLI argument and related logging from training configuration - Updated help text documentation to reflect that models no longer use telescope multiplicity suffixes
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/eventdisplay_ml/hyper_parameters.py | Removed unused n_tel parameter from pre_cuts_regression() and pre_cuts_classification() function signatures and docstrings |
| src/eventdisplay_ml/config.py | Removed --n_tel CLI argument, associated logging statement, and updated function calls to match new signatures; updated help text to remove references to n_tel suffix |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.