Shorten state in crash reports#163
Merged
zuiderkwast merged 1 commit intoEricsson:mainfrom Mar 20, 2026
Merged
Conversation
Using the gen_server format_status/1 callback, rewrite the state for crash dumps in the following ways: 1. Convert from record to map, so keys are readable 2. Replace the huge binary slot map with a list of ranges Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Collaborator
Author
|
This failed test shows the new crash report: https://github.com/zuiderkwast/ered/actions/runs/23345634795/job/67910132639#step:5:118 (The test case was flaky before and not affected by this PR.) |
bjosv
approved these changes
Mar 20, 2026
Collaborator
bjosv
left a comment
There was a problem hiding this comment.
Very cool, looks a lot better.
| code_change(_OldVsn, State = #st{}, _Extra) -> | ||
| {ok, State}. | ||
|
|
||
| format_status(Status) -> |
Collaborator
There was a problem hiding this comment.
This just affects OTP25+ I guess, but thats fine.
format_status(Status) (since OTP 25.0) (optional)
Collaborator
Author
There was a problem hiding this comment.
Yeah, it will just be ignored on OTP < 25.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the gen_server callback format_status/1, rewrite the state used for crash dumps in the following ways:
Before:
After: