Add support for sending commands in batches#158
Merged
zuiderkwast merged 5 commits intoEricsson:single-process-clientfrom Mar 17, 2026
Merged
Conversation
* Bonus:
Avoid pattern matching in
eunit tests to verify output/input,
leads to ambigious function clause
errors when clause does not match.
Change-Id: I9e234753c424e520c4d388039919aebc1c1f93f6
zuiderkwast
reviewed
Mar 2, 2026
Collaborator
There was a problem hiding this comment.
Imlementation looks good. I have some comments about naming and style.
I don't see any tests where pending reaches the maximum and we start building up batches. Is this already covered in some cluster test? If not, we should probably do it in ered_client_tests.
zuiderkwast
changed the title
WilliamVoong
force-pushed
the
victor/single-process-client
branch
from
cba9b6d to
04f65f9
Compare
WilliamVoong
force-pushed
the
victor/single-process-client
branch
from
04f65f9 to
27bc752
Compare
zuiderkwast
approved these changes
Mar 16, 2026
Collaborator
zuiderkwast
left a comment
zuiderkwast
left a comment
There was a problem hiding this comment.
Looks great now. Only very minor comments now.
added 2 commits
March 16, 2026 14:51
* Fix wrong types in docs and code. * Make low_high_watermark test more complete. * Some small refactoring in ered_client_tests * Add some docs for filling_batch.
zuiderkwast
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the pending queue is full, don't send more commands until the pending queue can fit another batch of commands, as configured with the existing config
batch_size.The purpose is to improve performance by sending fewer and larger TCP packets.
The config for
batch_sizehas existed before but the batching functionality has not worked properly.Bonus: Use assert macros instead of direct pattern matching in eunit tests to verify output/input, to get better error messages on failure.