Skip to content

⚡ Bolt: [performance improvement] Optimize texture sampling std::floor #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
google-labs-jules wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡ Bolt: [performance improvement] Optimize texture sampling std::floor #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions include/soft_render/core/texture.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ class Texture {
if (width_ == 0 || height_ == 0) return {1, 1, 1};

// Wrap
u = u - std::floor(u);
v = v - std::floor(v);
int iu = static_cast<int>(u); u = u - static_cast<float>(iu - (iu > u));
int iv = static_cast<int>(v); v = v - static_cast<float>(iv - (iv > v));

float fx = u * (width_ - 1);
float fy = v * (height_ - 1);
Expand All @@ -58,8 +58,8 @@ class Texture {
// Nearest-neighbor (faster)
math::Color sampleNearest(float u, float v) const {
if (width_ == 0 || height_ == 0) return {1, 1, 1};
u = u - std::floor(u);
v = v - std::floor(v);
int iu = static_cast<int>(u); u = u - static_cast<float>(iu - (iu > u));
int iv = static_cast<int>(v); v = v - static_cast<float>(iv - (iv > v));
int x = static_cast<int>(u * width_) % width_;
int y = static_cast<int>(v * height_) % height_;
return fetch(x, y);
Expand Down