Add employee cards, filters, and selection behavior with “You” contact card fallback#65
Conversation
Thomasbenissan
left a comment
There was a problem hiding this comment.
Updated this PR to align with issue #58 and the current directory architecture. Key changes made:\n\n- moved implementation into existing flow instead of the alternate dashboard/root component stack\n- added a full profile side panel under search/filters with view and edit states\n- added self-only edit controls (view others, edit your own profile)\n- added profile photo upload in edit mode with immediate preview\n- added editable profile fields (name, position, department, location, bio, contact, birthday) and explicit non-mutable fields (employee ID, email)\n- wired search + department/role/location filters into directory state and results rendering\n- kept selection behavior so clicking empty results space resets selection to the current user\n- removed duplicate temporary components/types introduced in the earlier version\n\nValidation run locally:\n- \n-
odyssey@0.0.1 lint
next lint
./src/components/hrservices/career-dev/CareerDev.tsx
284:11 Warning: Using <img> could result in slower LCP and higher bandwidth. Consider using <Image /> from next/image or a custom image loader to automatically optimize images. This may incur additional usage or cost from your provider. See: https://nextjs.org/docs/messages/no-img-element @next/next/no-img-element
info - Need to disable some ESLint rules? Learn more here: https://nextjs.org/docs/basic-features/eslint#disabling-rules (passes; one unrelated existing warning in )\n
Thomasbenissan
left a comment
There was a problem hiding this comment.
Updated this PR to align with issue #58 and the current directory architecture. Key changes made:\n\n- moved implementation into existing src/components/directory flow instead of the alternate dashboard/root component stack\n- added a full profile side panel under search/filters with view and edit states\n- added self-only edit controls (view others, edit your own profile)\n- added profile photo upload in edit mode with immediate preview\n- added editable profile fields (name, position, department, location, bio, contact, birthday) and explicit non-mutable fields (employee ID, email)\n- wired search + department/role/location filters into directory state and results rendering\n- kept selection behavior so clicking empty results space resets selection to the current user\n- removed duplicate temporary components/types introduced in the earlier version\n\nValidation run locally:\n- npx tsc --noEmit\n- npm run lint (passes; one unrelated existing warning in CareerDev.tsx)\n
Thomasbenissan
left a comment
There was a problem hiding this comment.
Implemented the requested #58 profile panel scope on this branch and validated locally. This is now aligned with the existing directory architecture and ready for merge once branch protection requirements are satisfied.
Summary
Testing