General improvements [Ready To Merge]#733
Closed
anar4732 wants to merge 15 commits intoElectrical-Age:developfrom
anar4732:develop
Closed
General improvements [Ready To Merge]#733anar4732 wants to merge 15 commits intoElectrical-Age:developfrom anar4732:develop
anar4732 wants to merge 15 commits intoElectrical-Age:developfrom
anar4732:develop
Conversation
The majority belong to marcin212
Marcin212 minetweakersupport
Member
|
Sorry, I am pretty busy the next weeks. @Baughn could you have a look at? |
cm0x4D
reviewed
Aug 6, 2017
Member
cm0x4D
left a comment
cm0x4D
left a comment
There was a problem hiding this comment.
LGTM - tested only one recipe with MineTweaker and it worked as expected.
The new exporter texture is nice too.
| public static MinetweakerIntegration instance = new MinetweakerIntegration(); | ||
|
|
||
|
|
||
| public void initialize(){ |
Member
There was a problem hiding this comment.
Could be static? If yes, there would be no need for a singleton...
cm0x4D
approved these changes
Aug 10, 2017
|
Heads up: Minetweaker support for removal does not work with any Recipe for the Plate Machine, Compressor, or Magnatizer. Not sure why, as I can add recipes just fine, and remove recipes from the Macerator just fine too. |
Member
|
I'm planning on implementing some sort of minetweaker support in with #652, which I've resumed work on recently. I'm not sure how that'll end up affecting this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made minor bug fixes.
It works very well.
import minetweaker.item.IIngredient;import mods.electricalage.Macerator;Macerator.addRecipe(<minecraft:wheat> as IIngredient, 1000.0, [<MyMod:itemA>, <MyMod:itemD>]);#307