Open
Conversation
argument is the name, not the object
Author
This was referenced May 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This fixes a few issues that kept the mod from running in mcl (there are probably more but with this it doesn't crash on load or spawning dragon or quickly after...):
Fixes #34
Fixes #32
Fixes #33
Fixes #36
Fixes #35
Cherry pick at the individual commits if you don't like all of them ... but at least the first 4 are undeniably correct imo ^^
More work needed
This fixes the mod to the point that draconis loads without crashes in mcl and dragons can be spawned and fight each other without crashing the game.
Probably still problematic:
As far as I have seen no "dragon nests" spawn in mcl probably because of the different node names haven't really looked into it yet.Dragon nests spawn on tree tops and probably other "weird" locations!?