Skip to content

fix(Daterange): accessibility fix for daterange picker#1100

Merged
mfazil-eightfold merged 9 commits intoEightfoldAI:mainfrom
ssherigar-c-eightfold:dtag/date-picker
Mar 16, 2026
Merged

fix(Daterange): accessibility fix for daterange picker#1100
mfazil-eightfold merged 9 commits intoEightfoldAI:mainfrom
ssherigar-c-eightfold:dtag/date-picker

Conversation

@ssherigar-c-eightfold
Copy link
Contributor

@ssherigar-c-eightfold ssherigar-c-eightfold commented Feb 25, 2026

SUMMARY:

Issue

  • The input field is always cleared when you move on with the TAB key
  • The focus is not moving to the action items of the datepicker on Tab
  • When opening the date field to type the date, it never registers the first number. It only opens the date picker

Before

Screen.Recording.2026-02-26.at.11.56.23.AM.mov

After

Screen.Recording.2026-02-25.at.9.04.48.PM.mov

GITHUB ISSUE (Open Source Contributors)

JIRA TASK (Eightfold Employees Only):

https://eightfoldai.atlassian.net/browse/ENG-171608

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

  • When the DatePicker is closed, pressing any character key opens it and the typed character appears in the input. Space and Enter also work correctly
  • In RangePicker, after selecting a date or pressing Escape, focus returns to the correct input (start or end).
  • After selecting the start date, focus correctly moves to the end panel/input, and after selecting the end date, the picker closes properly
  • Focus remains inside the picker when trapFocus is enabled
  • Input should not be cleared on Tab

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 25, 2026

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@mfazil-eightfold mfazil-eightfold merged commit 734474f into EightfoldAI:main Mar 16, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants