Open
Conversation
Added request
added set fan speed via url call
Author
|
Added changes to update fan speed via URL |
Owner
|
This looks great! Thanks for putting it together. My only concern with your implementation is the security aspect - with how you have it set anyone on the LAN will be able to control the servers fan speed which seems like a risk (especially as manual fan speed will not ramp up if the server begins to overheat). It would be nice to introduce two controls - first an environment arg that enables this feature and second an "api key" style secret that needs to be passed with the request for authentication. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.