Move import options into import private key scene#5982
Open
Move import options into import private key scene#5982
Conversation
Resolves the warning Require cycle: src/plugins/stake-plugins/uniswapV2/policyInfo/fantom.ts -> src/plugins/stake-plugins/uniswapV2/policyInfo/fantom.ts Require cycles are allowed, but can result in uninitialized values. Consider refactoring to remove the need for a cycle.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The current import key scene calls
importKeywithout any options as a test. This isn't ideal for plugins that do import options validations in that function. Some plugins fake it or have workarounds for missing options.Included are some unrelated fixes for warnings seen while debugging.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have:
Note
Medium Risk
Changes the wallet import flow by collecting and passing plugin-specific
keyOptionsintoimportKeyand wallet creation, which could affect imports for multiple currencies if validation/option handling differs. Also touches staking plugin wiring and memoized selector defaults, but those are low-impact.Overview
Wallet import flow: Removes the separate
CreateWalletImportOptionsSceneand integrates per-pluginimportKeyOptionscollection/editing directly intoCreateWalletImportScene, including inline validation, help links, and disabling the Next button until required inputs are valid. The import “test” now callscurrencyConfig[pluginId].importKey(importText, { keyOptions })and passeskeyOptionsthrough tocreateWalletCompletionfor final wallet creation.Staking cleanup: Introduces
EMPTY_STAKE_POSITION_MAPto avoid creating a new empty object on each render, and fixes Fantom UniswapV2 stake plugins to break a cyclic import by extracting the ecosystem setup intofantomEcosystem.ts(plus a few small boolean/type-safety tweaks).Written by Cursor Bugbot for commit 9cdb7c1. This will update automatically on new commits. Configure here.