Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
b672ee4 to
8cda7cb
Compare
samholmes
left a comment
There was a problem hiding this comment.
I think this makes sense. But I think a short review-bar is all that's needed.
There was a problem hiding this comment.
I don't understand this commit much. Why were the type deprecated. I guess maybe a little sidebar?
There was a problem hiding this comment.
RN navigation 7 will no longer allow NavigationBase and requires typed navigators only, that's why it was deprecated in the first place. We need to prepare for the transition eventually so we must do it incrementally.
On second thought, though, this commit might not be a valid workaround. We might just need to actually fix everything such that we lift navigator props out of all components using NavigationBase
samholmes
left a comment
There was a problem hiding this comment.
Approved if we drop first commit because it's not certain if it's useful
3b6651a to
ac96506
Compare
Clean up the existing contacts permission modal warnings so the feature work can build on a warning-free file.
Prevent contact permission prompts from appearing during passive thumbnail lookups and limit them to transaction-list or explicit payee edit flows.
ac96506 to
43bea65
Compare

CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
none
Requirements
If you have made any visual changes to the GUI. Make sure you have:
Description
Asana task
Remove contacts modal on first receive. The contacts permission prompt no longer appears from passive thumbnail lookup when a user receives funds. It now appears only when the user opens a transaction list with named transactions or explicitly edits the payee field from transaction details.
Note
Low Risk
Low risk: changes are isolated to UI permission-prompt timing and removes a side-effect from a thumbnail hook, with no sensitive data handling beyond existing permission requests.
Overview
Adjusts when the contacts permission modal is shown so it no longer triggers during passive contact thumbnail lookup (e.g. first receive).
Centralizes the “show modal + request OS permission” behavior into a new
promptForContactsPermissionthunk, calls it fromContactListModal, and adds a guard inTransactionListSceneto only prompt when there are named transactions.Simplifies
useContactThumbnailto be a pure lookup over existing contacts state (no permission checks/modals), and updates the changelog entry to reflect the new prompt timing.Written by Cursor Bugbot for commit 43bea65. This will update automatically on new commits. Configure here.