Skip to content

Fix contacts permission prompt timing#5979

Merged
j0ntz merged 2 commits intodevelopfrom
jon/fix/remove-contacts-modal-first-receive
Mar 20, 2026
Merged

Fix contacts permission prompt timing#5979
j0ntz merged 2 commits intodevelopfrom
jon/fix/remove-contacts-modal-first-receive

Conversation

@j0ntz
Copy link
Contributor

@j0ntz j0ntz commented Mar 13, 2026

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

Description

Asana task

Remove contacts modal on first receive. The contacts permission prompt no longer appears from passive thumbnail lookup when a user receives funds. It now appears only when the user opens a transaction list with named transactions or explicitly edits the payee field from transaction details.


Note

Low Risk
Low risk: changes are isolated to UI permission-prompt timing and removes a side-effect from a thumbnail hook, with no sensitive data handling beyond existing permission requests.

Overview
Adjusts when the contacts permission modal is shown so it no longer triggers during passive contact thumbnail lookup (e.g. first receive).

Centralizes the “show modal + request OS permission” behavior into a new promptForContactsPermission thunk, calls it from ContactListModal, and adds a guard in TransactionListScene to only prompt when there are named transactions.

Simplifies useContactThumbnail to be a pure lookup over existing contacts state (no permission checks/modals), and updates the changelog entry to reflect the new prompt timing.

Written by Cursor Bugbot for commit 43bea65. This will update automatically on new commits. Configure here.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

@j0ntz j0ntz force-pushed the jon/fix/remove-contacts-modal-first-receive branch from b672ee4 to 8cda7cb Compare March 13, 2026 22:38
Copy link
Contributor

@samholmes samholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense. But I think a short review-bar is all that's needed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this commit much. Why were the type deprecated. I guess maybe a little sidebar?

Copy link
Contributor Author

@j0ntz j0ntz Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RN navigation 7 will no longer allow NavigationBase and requires typed navigators only, that's why it was deprecated in the first place. We need to prepare for the transition eventually so we must do it incrementally.

On second thought, though, this commit might not be a valid workaround. We might just need to actually fix everything such that we lift navigator props out of all components using NavigationBase

Copy link
Contributor

@samholmes samholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved if we drop first commit because it's not certain if it's useful

@j0ntz j0ntz force-pushed the jon/fix/remove-contacts-modal-first-receive branch 2 times, most recently from 3b6651a to ac96506 Compare March 20, 2026 02:37
j0ntz added 2 commits March 19, 2026 19:44
Clean up the existing contacts permission modal warnings so the feature work can build on a warning-free file.
Prevent contact permission prompts from appearing during passive thumbnail lookups and limit them to transaction-list or explicit payee edit flows.
@j0ntz j0ntz force-pushed the jon/fix/remove-contacts-modal-first-receive branch from ac96506 to 43bea65 Compare March 20, 2026 02:44
@j0ntz j0ntz merged commit 0ede90e into develop Mar 20, 2026
3 of 4 checks passed
@j0ntz j0ntz deleted the jon/fix/remove-contacts-modal-first-receive branch March 20, 2026 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants