Fix: Use initialized mix fetch instance on Android#714
Open
bobbythelobster wants to merge 4 commits intoEdgeApp:masterfrom
Open
Fix: Use initialized mix fetch instance on Android#714bobbythelobster wants to merge 4 commits intoEdgeApp:masterfrom
bobbythelobster wants to merge 4 commits intoEdgeApp:masterfrom
Conversation
The @nymproject/mix-fetch library now handles concurrency natively, so the custom per-host serialization queue is no longer needed. queueMixFetch is now a thin pass-through to mixFetch. Made-with: Cursor
Remove the queueMixFetch wrapper from util/nym and call mixFetch inline at browser and react-native NYM call sites. This follows PR feedback and reduces unnecessary abstraction while keeping initMixFetch setup behavior unchanged.
Made-with: Cursor
The initMixFetch() function returns a properly initialized IMixFetch instance, but the code was discarding it and calling the raw mixFetch() function instead. On Android, the raw function uses an uninitialized WASM context, causing a panic. Fix: Store and use the returned IMixFetch instance in both react-native-io and browser-io fetch handlers. Fixes the 'panic: JavaScript error: mix fetch hasn'\''t been initialised' error on Android while keeping it working on iOS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the mix fetch panic on Android by storing and using the initialized IMixFetch instance returned from initMixFetch() instead of discarding it.