Remove NYM mixFetch per-host queue#712
Open
bobbythelobster wants to merge 3 commits intoEdgeApp:masterfrom
Open
Remove NYM mixFetch per-host queue#712bobbythelobster wants to merge 3 commits intoEdgeApp:masterfrom
bobbythelobster wants to merge 3 commits intoEdgeApp:masterfrom
Conversation
The @nymproject/mix-fetch library now handles concurrency natively, so the custom per-host serialization queue is no longer needed. queueMixFetch is now a thin pass-through to mixFetch. Made-with: Cursor
samholmes
requested changes
Mar 3, 2026
src/util/nym.ts
Outdated
| * mixFetch only allows one concurrent request per host, so we chain them. | ||
| * Thin wrapper around mixFetch with pre-configured options. | ||
| */ | ||
| export async function queueMixFetch( |
Contributor
There was a problem hiding this comment.
We don't need queueMixFetch at all. We can just inline mixFetch where queueMixFetch is being invoked.
Remove the queueMixFetch wrapper from util/nym and call mixFetch inline at browser and react-native NYM call sites. This follows PR feedback and reduces unnecessary abstraction while keeping initMixFetch setup behavior unchanged.
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
was upgraded in 2.43.1 for native concurrency improvements. Keeping our own host queue can unnecessarily serialize NYM traffic and increase timeout risk.
Validation
Risk