Remove builtin tokens by peachbits · Pull Request #710 · EdgeApp/edge-core-js

peachbits · 2026-02-26T07:15:33Z

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

Yes
No

Dependencies

none

Description

none

Note

Medium Risk
Token plumbing and persistence paths are reworked (builtins now loaded from bundled JSON and merged into customTokens), which could affect token visibility/enabling and legacy migrations if edge cases are missed.

Overview
Removes the separate builtinTokens state and login-time builtin loading; allTokens is now served directly from customTokens.

Adds bundled builtinTokens.json loading (via Rollup JSON support) and a batch addCustomTokens/ACCOUNT_CUSTOM_TOKENS_ADDED path to merge tokens efficiently, enabling migration of builtin/legacy-enabled tokens into customTokens. Also extends EdgeToken parsing with an optional isUserCreated flag.

^{Written by Cursor Bugbot for commit 8fbb8f0. This will update automatically on new commits. Configure here.}

To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1213144455230484

src/core/account/custom-tokens.ts

src/core/account/account-cleaners.ts

…ctions Certain legacy functionality needs to rely on the tokens being present. They can use the local json if necessary

swansontec · 2026-02-27T01:04:53Z

src/types/types.ts

  canReplaceByFee?: boolean // Defaults to false
  customFeeTemplate?: EdgeObjectTemplate // Indicates custom fee support
-  customTokenTemplate?: EdgeObjectTemplate // Indicates custom token support
+  customTokenTemplate?: EdgeObjectTemplate // An empty array indicates token support. A filled array indicates custom token support.


I don't like this. It's too subtle, and makes the code hard to understand. Let's add an explicit hasTokens?: boolean instead, and leave customTokenTemplate just for custom token support.

swansontec · 2026-02-27T02:20:52Z

src/core/account/custom-tokens.ts

+  const enabledTokensByPlugin = new Map<string, Set<string>>()
+
+  // Get all wallet IDs for this account
+  const walletIds = accountState.currencyWalletIds


I am deeply concerned about when this migration happens. The problem is that the list of wallets may be out of date on the device, and then once the data sync takes place, the newly-discovered wallets will not receive the migration. Instead, I would expect this migration to happen as part of the loadTokensFile function, which would use your giant JSON to upgrade currencyCodes. Then, once loadTokensFile returns, the engine pixie can do a diff with the accountState.customTokens[pluginId] and insert any enabled tokens that we find in your big JSON but not in the custom token list.

Moving the migration to the engine-start logic would also eliminate Cursor's worry about uninitialized storage.

This revised plan might be a little slower on first-migrate, but should be faster and more stable long-term.

swansontec · 2026-02-27T02:29:04Z

src/core/currency/wallet/currency-wallet-files.ts

 const LEGACY_TOKENS_FILE = 'EnabledTokens.json'
 const SEEN_TX_CHECKPOINT_FILE = 'seenTxCheckpoint.json'
-const TOKENS_FILE = 'Tokens.json'
+export const TOKENS_FILE = 'Tokens.json'


If we move the migration logic to engine-start, as described above, this can go back to being file-private as it should be. We really do want to keep all disk IO in this one source file so it's easy to audit & understand.

swansontec · 2026-02-27T02:47:54Z

src/core/currency/wallet/currency-wallet-reducer.ts

+            continue
+          }
+          currencyCode = allTokens[tokenId].currencyCode
+        }


The GUI no longer uses the old .balances table, which is currency-code based. Could we just remove it as part of the breaking change?

swansontec · 2026-02-27T02:48:43Z

src/core/currency/wallet/currency-wallet-pixie.ts

          engine.disableTokens != null &&
          engine.enableTokens != null
        ) {
+          const builtinTokens = loadBuiltinTokensJson()


The engines no longer implement disableTokens or enableTokens, which are currency-code based. Can we just remove those options as part of the breaking change?

swansontec · 2026-02-27T02:51:25Z

src/core/account/account-reducer.ts


  allTokens(state = {}, action, next, prev): EdgePluginMap<EdgeTokenMap> {
-    const { builtinTokens, customTokens } = next.self
+    const { customTokens } = next.self


We can gut this whole reducer, now that allTokens is just an alias for customTokens. It could become simply:

allTokens(state = {}, action, next, prev): EdgePluginMap<EdgeTokenMap> { return next.self.customTokens }

swansontec · 2026-02-27T02:52:48Z

src/core/account/plugin-api.ts

-    const { state } = this._ai.props
-    const { _accountId: accountId, _pluginId: pluginId } = this
-    return state.accounts[accountId].builtinTokens[pluginId]
+    return state.accounts[accountId].allTokens[pluginId] ?? emptyTokens


The ?? emptyTokens is not needed, as the updated reducer can never return undefined.

swansontec · 2026-02-27T02:52:58Z

src/core/currency/wallet/currency-wallet-api.ts

-      const accountState = input.props.state.accounts[accountId]
-      const allTokens = accountState.allTokens[pluginId] ?? {}
-
+      const allTokens =


The ?? {} is not needed, as the updated reducer can never return undefined.

swansontec · 2026-02-27T02:53:54Z

src/core/currency/wallet/currency-wallet-api.ts

+        input.props.state.accounts[accountId].allTokens[pluginId] ?? {}
      const enabledTokenIds = uniqueStrings(tokenIds).filter(
-        tokenId => allTokens[tokenId] != null
+        tokenId => tokenId in allTokens


I prefer the tokenId => allTokens[tokenId] != null test, which is more robust.

swansontec · 2026-02-27T02:54:52Z

test/core/currency/wallet/currency-wallet.test.ts

    expect(config.allTokens).deep.equals({
-      ...config.customTokens,
-      ...config.builtinTokens
+      ...config.customTokens


We don't need the {...} anymore, but can simply use customTokens directly now.

This reverts commit 46dc32c.

…acy functions

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

cursor · 2026-02-27T07:27:19Z

src/core/account/account-reducer.ts

  ),

  allTokens(state = {}, action, next, prev): EdgePluginMap<EdgeTokenMap> {
-    const { builtinTokens, customTokens } = next.self


allTokens[pluginId] now undefined causing runtime crashes

High Severity

The allTokens reducer now returns next.self.customTokens directly, but customTokens only contains entries for plugins that have explicitly stored tokens. The old reducer iterated over all currency plugins and created entries for each (even empty {}), guaranteeing allTokens[pluginId] was always an object. Now allTokens[pluginId] returns undefined for any plugin without custom tokens. Multiple consumers access allTokens[pluginId] without null guards — e.g., changeEnabledTokenIds does allTokens[tokenId] on the result, and getCurrencyMultiplier/upgradeCurrencyCode call Object.keys(allTokens) — all of which throw TypeError when allTokens is undefined. This affects non-token chains like Bitcoin and any wallet whose plugin has no migrated or user-created tokens yet.

Additional Locations (1)

src/core/account/plugin-api.ts#L53-L58

Describe how customTokenTemplate should be used

a475723

cursor bot reviewed Feb 26, 2026

View reviewed changes

src/core/account/custom-tokens.ts Outdated Show resolved Hide resolved

src/core/account/account-cleaners.ts Outdated Show resolved Hide resolved

peachbits added 3 commits February 26, 2026 00:09

Make sure enabled tokens exist in customTokens object

8d51b03

Use builtinTokens.json over accountState.builtinTokens for legacy fun…

88730ae

…ctions Certain legacy functionality needs to rely on the tokens being present. They can use the local json if necessary

Make currencyCode access safer

46dc32c

peachbits force-pushed the matthew/builtin-tokens branch from 0225b98 to c5a4453 Compare February 26, 2026 08:15

peachbits added 3 commits February 26, 2026 00:16

Remove builtinTokens

36a0d59

Add isUserCreated to EdgeToken

98c9a50

Add addCustomTokens to CurrencyConfig

7613aff

peachbits force-pushed the matthew/builtin-tokens branch from c5a4453 to 7613aff Compare February 26, 2026 08:16

swansontec requested changes Feb 27, 2026

View reviewed changes

peachbits added 7 commits February 26, 2026 21:25

fixup! Describe how customTokenTemplate should be used

7680874

Revert "Make currencyCode access safer"

1b2fe7b

This reverts commit 46dc32c.

Remove balances

3f9b5f3

fixup! Use builtinTokens.json over accountState.builtinTokens for leg…

16784c4

…acy functions

fixup! Remove builtinTokens

568b357

fixup! Remove builtinTokens

f3cda44

fixup! Make sure enabled tokens exist in customTokens object

8fbb8f0

cursor bot reviewed Feb 27, 2026

View reviewed changes

Conversation

peachbits commented Feb 26, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CHANGELOG

Dependencies

Description

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor bot Feb 27, 2026

Choose a reason for hiding this comment

allTokens[pluginId] now undefined causing runtime crashes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

peachbits commented Feb 26, 2026 •

edited by cursor bot

Loading

`allTokens[pluginId]` now undefined causing runtime crashes