Cache and restore wallets by paullinator · Pull Request #703 · EdgeApp/edge-core-js

paullinator · 2026-02-04T05:43:59Z

Improve login performance by caching wallet state on a per account level in unencrypted JSON file and rehydrate before wallets load.

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

Yes
No

Dependencies

none

Description

none

Note

Medium Risk
Touches the core login/account wallet plumbing and introduces new persistence/rehydration behavior, which could affect wallet lists or startup edge-cases if the cache becomes stale or invalid.

Overview
Adds a cache-first login path that restores lightweight EdgeCurrencyWallet/EdgeCurrencyConfig objects from accountCache/<storageWalletId>/walletCache.json so the UI can show wallets immediately while real engines load in the background.

Implements a new wallet-cache subsystem (schema cleaners, loader, cached delegating wallet/config with shared poller, delegating otherMethods and disklets) plus a throttled, dirty-triggered saver wired into account-pixie to keep the cache updated; makeAccountApi now merges cached and real wallets/IDs until keys/wallets are fully loaded. Also tightens swap-quote cleanup logging, exports asEdgeToken for reuse, and adds extensive end-to-end tests (with a gated fake engine) covering cache save/load, delegation, yaob propagation, and disklet behavior.

^{Written by Cursor Bugbot for commit 049daf9. This will update automatically on new commits. Configure here.}

To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1213362108709046
- https://app.asana.com/0/0/1213598116503346

src/core/cache/cache-wallet-loader.ts

src/core/account/account-pixie.ts

src/core/account/account-api.ts

src/core/account/account-pixie.ts

src/core/cache/cached-currency-wallet.ts

src/core/cache/cache-utils.ts

src/core/cache/cached-currency-config.ts

src/core/account/account-pixie.ts

src/core/cache/cached-currency-config.ts

cursor · 2026-02-23T23:34:58Z

src/core/account/account-pixie.ts

+  }
+  const errorWithCode = error as Error & { code?: string }
+  return errorWithCode.code === 'ENOENT'
+}


File-not-found detection is too fragile

Low Severity

isFileNotFoundError depends on exact, case-sensitive Error.message prefixes ('Cannot load', 'Cannot read file') to detect missing cache files. If disklet changes wording/casing or platform-specific messages differ, first-login “missing cache” can be misclassified as unexpected and logged as a warning.

cursor

Cursor Bugbot has reviewed your changes and found 2 potential issues.

^{Bugbot Autofix is ON. A Cloud Agent has been kicked off to fix the reported issues.}

cursor · 2026-02-23T23:39:31Z

src/core/cache/cached-currency-config.ts

+    get userSettings(): object | undefined {
+      const realConfig = tryGetRealConfig()
+      return realConfig != null ? realConfig.userSettings : {}
+    },


Cached config returns empty userSettings

Medium Severity

The cached EdgeCurrencyConfig.userSettings getter returns {} when the real config is unavailable, even though the type is object | undefined. This changes semantics for callers that distinguish “no settings yet” (undefined) from “settings exist” (object), and can cause cache-mode behavior to diverge from real-config behavior.

cursor · 2026-02-23T23:39:32Z

src/core/cache/cached-currency-wallet.ts

+    // Data store:
+    get created(): Date | undefined {
+      return createdDate
+    },


Cached wallet created date may be invalid

Low Severity

makeCachedCurrencyWallet converts cacheData.created to createdDate = new Date(createdString) and always returns it from created. If the cache has an invalid or non-ISO created string, created becomes an “Invalid Date” object instead of undefined, which can break consumers that assume a valid Date.

cursor · 2026-02-23T23:43:31Z

Bugbot Autofix prepared fixes for 2 of the 2 bugs found in the latest run.

✅ Fixed: Cached config returns empty userSettings
- Changed the userSettings getter to return undefined instead of {} when the real config is unavailable, preserving the semantic distinction between 'no settings' and 'settings exist'.
✅ Fixed: Cached wallet created date may be invalid
- Added validation to check if the parsed date is valid using isNaN(parsedDate.getTime()), returning undefined for invalid date strings instead of an Invalid Date object.

Or push these changes by commenting:

@cursor push e6e1588d29

Preview (e6e1588d29)

diff --git a/src/core/cache/cached-currency-config.ts b/src/core/cache/cached-currency-config.ts
--- a/src/core/cache/cached-currency-config.ts
+++ b/src/core/cache/cached-currency-config.ts
@@ -141,7 +141,7 @@
     // User settings (delegate when available, write delegates):
     get userSettings(): object | undefined {
       const realConfig = tryGetRealConfig()
-      return realConfig != null ? realConfig.userSettings : {}
+      return realConfig != null ? realConfig.userSettings : undefined
     },
 
     async changeUserSettings(settings: object): Promise<void> {

diff --git a/src/core/cache/cached-currency-wallet.ts b/src/core/cache/cached-currency-wallet.ts
--- a/src/core/cache/cached-currency-wallet.ts
+++ b/src/core/cache/cached-currency-wallet.ts
@@ -155,7 +155,8 @@
   } = cacheData
 
   const shortId = walletId.slice(0, WALLET_ID_DISPLAY_LENGTH)
-  const createdDate = new Date(createdString)
+  const parsedDate = new Date(createdString)
+  const createdDate = isNaN(parsedDate.getTime()) ? undefined : parsedDate
 
   // Track mutable state locally. When the GUI calls a setter, we update
   // the local value immediately and call update(wallet) to push it

paullinator · 2026-02-24T06:42:56Z

/rebase

swansontec · 2026-02-26T19:06:03Z

src/core/account/account-api.ts

+          result[walletId] = wallet
+        }
+      }
+      return result


Because YAOB diffs objects shallowly (===), this needs to be referrentially stable. So you need to store the object somewhere and replace it each time something inside changes. Otherwise we'll either get superfluous updates or missing updates (either would be bad).

@ts-expect-error

Add missing return in fake plugin getBalance for token balance. Improve @ts-expect-error comment and log swap quote close errors. Co-authored-by: Cursor <cursoragent@cursor.com>

Improve login performance by caching wallet state on a per account level in unencrypted JSON file and rehydrate before wallets load.

paullinator force-pushed the paul/cacheWallets branch from 8b8cd1a to 53a3312 Compare February 4, 2026 05:44

cursor bot reviewed Feb 4, 2026

View reviewed changes

src/core/cache/cache-wallet-loader.ts Show resolved Hide resolved