Int_significance.R updated

[verducam]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @verducam, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on improving the user experience and maintainability of the int_significance function. It provides extensive documentation to clarify the function's statistical methodology and output, while also refining the associated test cases for better efficiency and readability. These changes collectively make the function easier to understand, use, and verify.

Highlights

• Enhanced Documentation for int_significance function: The Roxygen documentation for the int_significance function has been significantly expanded. This includes a detailed description of its purpose, the statistical tests employed (binomial and chi-square), and the interpretation of 'not testable' interactions. The @param int_type and @returns sections now provide comprehensive explanations of their options and output, respectively, improving clarity for users.
• Simplified Test Data Loading: The test suite for int_significance has been streamlined by directly using Amoladeras_int and Amoladeras_cover datasets. This change removes redundant data loading and subsetting operations within each test, making the tests cleaner and more efficient.
• Improved Code Readability: The stop and message calls within the int_significance function have been reformatted to span multiple lines, enhancing the readability of error and informational messages.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• R/int_significance.R
  • Updated Roxygen documentation with a detailed description, parameter explanations, and return value definitions.
  • Reformatted stop and message calls for improved code readability.
• tests/testthat/test-int_significance.R
  • Removed explicit data loading and subsetting, directly using Amoladeras_int and Amoladeras_cover for tests.

Activity

• No specific human activity (comments, reviews) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request significantly improves the documentation for the int_significance function and updates the test suite to use the package's internal datasets. However, there is a critical logic error in how the int_type argument is handled when it defaults to a vector, which will cause errors in recent R versions. Additionally, several user-facing messages contain unnecessary indentation due to being split across multiple lines in the source code. I have provided suggestions to fix these issues and improve overall code readability and consistency.