Skip to content

Fix mp_hal_stdout_tx_strn(): use ssize_t, loop for partial writes, handle EINTR #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morita5840 merged 2 commits into from
Mar 21, 2026
Merged

Fix mp_hal_stdout_tx_strn(): use ssize_t, loop for partial writes, handle EINTR #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6064fa6
Initial plan
Copilot Mar 21, 2026
2395918
Fix mp_hal_stdout_tx_strn(): use ssize_t, loop for partial writes, ha…
Copilot Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions bricks/ev3dev/ev3dev_mphal.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,10 +110,25 @@ int mp_hal_stdin_rx_chr(void) {
}

mp_uint_t mp_hal_stdout_tx_strn(const char *str, size_t len) {
MP_THREAD_GIL_EXIT();
int ret = write(STDOUT_FILENO, str, len);
MP_THREAD_GIL_ENTER();
return ret < 0 ? 0 : ret;
size_t remaining = len;
while (remaining > 0) {
MP_THREAD_GIL_EXIT();
ssize_t ret = write(STDOUT_FILENO, str, remaining);
MP_THREAD_GIL_ENTER();
if (ret < 0) {
if (errno == EINTR) {
continue;
}
return len - remaining;
}
/* Defensive check: POSIX guarantees ret <= remaining, but guard against non-compliant implementations. */
if ((size_t)ret > remaining) {
return len;
}
str += ret;
remaining -= (size_t)ret;
}
return len;
}

// cooked is same as uncooked because the terminal does some postprocessing
Expand Down