Replaced tensorrt.tensorrt imports to tensorrt for pip package compatibility#181
Open
CorentinJ wants to merge 2 commits intoELS-RD:mainfrom
Open
Replaced tensorrt.tensorrt imports to tensorrt for pip package compatibility#181CorentinJ wants to merge 2 commits intoELS-RD:mainfrom
CorentinJ wants to merge 2 commits intoELS-RD:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
tensorrtpip package seems not to havetensorrt.tensorrtas module (at least as of version tensorrt==8.6.1.post1), causing 3 imports to fail in the repo. The same members imported fromtensorrt.tensorrtare present directly intensorrt.It seems that a manual install of Tensor RT (through an archive or .deb package) does not have this problem, but that the members present in
tensorrt.tensorrtare equally present intensorrt.I haven't gone through the tensorrt changelog to figure out what happened there; but unless this breaks compatibility with older tensorrt versions, changing all
tensorrt.tensorrtimports totensorrtwill work with both install methods.