Merged
Conversation
Contributor
|
This fix is OK, but it is an API breaking change. We can file a new PR for this fix and merge it when new major, such as version 3.x, is ready. |
Collaborator
Author
|
We would merge the 3dview-wrapper commits after version 3.x. Track it with link: #2290 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #2000
An API breaking change is made, the main 3d view classes have their base class changed. Any code that relied on the base class now breaks.
DynamoRaas functionality also now is broken because those nodes expected view3d types and now all 3d views have a base class of Abstract3dView.
FYI: @ksobon