Skip to content

feat(RaidLogAuto): add ACL auto-enable and CombatLog.txt reminder#18

Merged
Xerrion merged 2 commits intomasterfrom
feat/rla-acl-combatlog-reminder
Mar 1, 2026
Merged

feat(RaidLogAuto): add ACL auto-enable and CombatLog.txt reminder#18
Xerrion merged 2 commits intomasterfrom
feat/rla-acl-combatlog-reminder

Conversation

@Xerrion
Copy link
Collaborator

@Xerrion Xerrion commented Mar 1, 2026

Description

Add two quality-of-life features that fire automatically when combat logging starts:

  1. Advanced Combat Logging (ACL) auto-enable - When the addon enables combat logging (entering a raid or M+ key), it checks if ACL is turned on. If not, it automatically enables the advancedCombatLogging CVar and notifies the user. This ensures WarcraftLogs/WoWAnalyzer uploads always have the detailed data they need.

  2. CombatLog.txt reminder dialog - A one-time StaticPopup dialog reminds the user to delete their CombatLog.txt before uploading logs. The dialog is "set-and-forget": once the user clicks "OK, Got It", the combatLogReminderDismissed SavedVariable is set to true and the dialog never appears again.

Additional changes:

  • New /rla acl slash command to manually check or enable ACL
  • ACL status shown in /rla status output
  • .luacheckrc updated with new globals (GetCVar, SetCVar, StaticPopupDialogs, StaticPopup_Show)
  • AGENTS.md updated with manual test steps for both features

All 5 version files updated consistently: Retail, Mists, Cata, TBC, Classic.

Type of Change

  • New feature (non-breaking change that adds functionality)

Related Issues

N/A

Testing

  • Luacheck passes (luacheck .) - all 5 version files pass clean
  • Tested in-game manually
  • WoW version(s) tested on:

Manual Test Checklist

ACL Auto-Enable:

  1. /console advancedCombatLogging 0 to disable ACL
  2. Enter a raid instance - verify chat: "Advanced Combat Logging was disabled. Automatically enabled it for you."
  3. /rla status should show "Advanced Combat Logging: ON"
  4. Re-enter - verify no duplicate message (already enabled)

CombatLog.txt Reminder:

  1. Reset: /run RaidLogAutoDB.combatLogReminderDismissed = false; ReloadUI()
  2. Enter a raid - verify StaticPopup dialog appears
  3. Click "OK, Got It" - dialog dismisses
  4. Re-enter - dialog does NOT reappear (permanently dismissed)

/rla acl Command:

  1. /rla acl with ACL on - shows "Advanced Combat Logging: ON"
  2. /console advancedCombatLogging 0 then /rla acl - enables and confirms

Checklist

  • My code follows the project's code style (4-space indent, 120 char lines)
  • I have tested my changes in-game
  • Luacheck reports no warnings
  • My commits follow conventional commit format

@Xerrion Xerrion force-pushed the feat/rla-acl-combatlog-reminder branch 2 times, most recently from 2c01ef8 to a5f9af3 Compare March 1, 2026 18:28
- Auto-enable Advanced Combat Logging when combat logging starts
- Show StaticPopup dialog reminding users to delete CombatLog.txt
- Dialog is set-and-forget: dismissed permanently on first acknowledgment
- Add /rla acl command to check/enable ACL manually
- Show ACL status in /rla status output
- All 5 version files updated (Retail, Mists, Cata, TBC, Classic)
@Xerrion Xerrion merged commit f4b79b1 into master Mar 1, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant