feat(RaidLogAuto): add ACL auto-enable and CombatLog.txt reminder#18
Merged
feat(RaidLogAuto): add ACL auto-enable and CombatLog.txt reminder#18
Conversation
2c01ef8 to
a5f9af3
Compare
- Auto-enable Advanced Combat Logging when combat logging starts - Show StaticPopup dialog reminding users to delete CombatLog.txt - Dialog is set-and-forget: dismissed permanently on first acknowledgment - Add /rla acl command to check/enable ACL manually - Show ACL status in /rla status output - All 5 version files updated (Retail, Mists, Cata, TBC, Classic)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add two quality-of-life features that fire automatically when combat logging starts:
Advanced Combat Logging (ACL) auto-enable - When the addon enables combat logging (entering a raid or M+ key), it checks if ACL is turned on. If not, it automatically enables the
advancedCombatLoggingCVar and notifies the user. This ensures WarcraftLogs/WoWAnalyzer uploads always have the detailed data they need.CombatLog.txt reminder dialog - A one-time StaticPopup dialog reminds the user to delete their
CombatLog.txtbefore uploading logs. The dialog is "set-and-forget": once the user clicks "OK, Got It", thecombatLogReminderDismissedSavedVariable is set totrueand the dialog never appears again.Additional changes:
/rla aclslash command to manually check or enable ACL/rla statusoutput.luacheckrcupdated with new globals (GetCVar,SetCVar,StaticPopupDialogs,StaticPopup_Show)AGENTS.mdupdated with manual test steps for both featuresAll 5 version files updated consistently: Retail, Mists, Cata, TBC, Classic.
Type of Change
Related Issues
N/A
Testing
luacheck .) - all 5 version files pass cleanManual Test Checklist
ACL Auto-Enable:
/console advancedCombatLogging 0to disable ACL/rla statusshould show "Advanced Combat Logging: ON"CombatLog.txt Reminder:
/run RaidLogAutoDB.combatLogReminderDismissed = false; ReloadUI()/rla acl Command:
/rla aclwith ACL on - shows "Advanced Combat Logging: ON"/console advancedCombatLogging 0then/rla acl- enables and confirmsChecklist