-
Notifications
You must be signed in to change notification settings - Fork 5
Optimise dockerfile & docker-compose #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ckdarby
wants to merge
1
commit into
Down2Jam:main
Choose a base branch
from
ckdarby:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,45 @@ | ||
| FROM node:18-alpine | ||
| # syntax=docker/dockerfile:1 | ||
|
|
||
| WORKDIR /usr/src/app | ||
| ARG NODE_VERSION=18 | ||
| ARG NODE_ENV=development | ||
|
|
||
| # --- Base Stage --- | ||
| FROM node:${NODE_VERSION}-alpine as base | ||
| WORKDIR /usr/src/app | ||
| # Install common dependencies (e.g. PostgreSQL client) | ||
| RUN apk add --no-cache postgresql-client | ||
| EXPOSE 3005 | ||
|
|
||
| COPY package*.json ./ | ||
| RUN npm install | ||
| # --- Dependencies Stage --- | ||
| FROM base as deps | ||
| # Copy package files first to leverage caching | ||
| COPY package.json package-lock.json ./ | ||
|
|
||
| # Use cache mount for npm downloads; conditionally install based on NODE_ENV | ||
| RUN --mount=type=cache,target=/root/.npm \ | ||
| if [ "$NODE_ENV" = "production" ]; then \ | ||
| npm ci --omit=dev; \ | ||
| else \ | ||
| npm ci --include=dev; \ | ||
| fi | ||
|
|
||
| # --- Builder Stage --- | ||
| FROM deps as builder | ||
| # Copy the rest of the application code | ||
| COPY . . | ||
| # Generate Prisma client (or other build steps) | ||
| RUN npx prisma generate | ||
|
|
||
| EXPOSE 3005 | ||
| # --- Development Final Stage --- | ||
| FROM base as dev | ||
|
|
||
| COPY --from=builder /usr/src/app ./ | ||
|
|
||
| CMD ["npm", "run", "dev"] | ||
|
|
||
| # --- Production Final Stage --- | ||
| FROM base as production | ||
|
|
||
| COPY --from=builder /usr/src/app ./ | ||
|
|
||
| CMD ["node", "index.js"] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,7 +12,10 @@ services: | |
| - postgres_data:/var/lib/postgresql/data/ | ||
|
|
||
| jamcore: | ||
| build: . | ||
| build: | ||
| context: . | ||
| dockerfile: Dockerfile | ||
| target: ${NODE_ENV:-dev} | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is default behavior. Use |
||
| environment: | ||
| DATABASE_URL: "postgresql://${POSTGRES_USER}:${POSTGRES_PASSWORD}@postgres:5432/${POSTGRES_DB}" | ||
| ports: | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you mentioned, you're not a docker person, I will note these are defaults and can be overridden. Thus why when
NODE_EVNis production on your production server it'll switch to that.I assumed that is how production works given the code has a section banking on
NODE_ENVviaenvfor URL to be either d2jam or localhost.